gcc7, gcc7Stdenv, gfortran7: remove old implementation#342242
Closed
trofi wants to merge 2 commits intoNixOS:masterfrom
Closed
gcc7, gcc7Stdenv, gfortran7: remove old implementation#342242trofi wants to merge 2 commits intoNixOS:masterfrom
trofi wants to merge 2 commits intoNixOS:masterfrom
Conversation
`gcc7` will soon be removed from `nixpkgs`. Switch the package to use a default version of `gcc`.
gcc-7.5.0 was released in Nov 14, 2019, 5 years ago. It's a branch that went out of support years ago. Numerous bugs never get backported to this version. Let's remove it.
Contributor
Author
|
Result of 1 package built:
|
Contributor
Author
|
If #342235 is merged earlier I can rebase past it to get 0 rebuilds on this PR. |
Contributor
Author
|
Will need |
Member
|
It needs to wait until after branch‐off; see #342112. I intend to remove GCCs 7 through 10 at that point to align with upstream’s support policy. (I have confirmed that all packages using GCC 9 should be possible to migrate off, and nothing uses 8. It’s possible 10 will have to stick around for now, depending on how that goes.) |
Member
|
Also QMK would need looking at, I think? |
Member
|
(Thank you for taking the charge in getting these cleaned up!) |
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
gcc-7.5.0 was released in Nov 14, 2019, 5 years ago. It's a branch that
went out of support years ago. Numerous bugs never get backported to
this version.
Let's remove it.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.