Skip to content

iproute2: fix building for musl with GCC 14#342002

Merged
alyssais merged 2 commits intoNixOS:stagingfrom
alyssais:iproute2-musl
Sep 16, 2024
Merged

iproute2: fix building for musl with GCC 14#342002
alyssais merged 2 commits intoNixOS:stagingfrom
alyssais:iproute2-musl

Conversation

@alyssais
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from fpletz, globin and primeos September 15, 2024 09:03
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Sep 15, 2024
@alyssais alyssais mentioned this pull request Sep 15, 2024
47 tasks
@alyssais
Copy link
Member Author

OfBorg failed on aarch64-linux because libaom is currently broken in staging due to a GCC ICE, which I have reported. We're discussing what to do about it in #staging:nixos.org.

@alyssais alyssais merged commit 98d8c29 into NixOS:staging Sep 16, 2024
@alyssais alyssais deleted the iproute2-musl branch September 16, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants