dotnet/build-dotnet-module: fix eval of fetch-deps#341497
Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom Sep 13, 2024
Merged
dotnet/build-dotnet-module: fix eval of fetch-deps#341497Aleksanaa merged 1 commit intoNixOS:masterfrom
fetch-deps#341497Aleksanaa merged 1 commit intoNixOS:masterfrom
Conversation
Without the change the eval fails as:
$ nix build --no-link -f. csharp-ls.fetch-deps --show-trace
error:
… while evaluating a path segment
at pkgs/build-support/dotnet/build-dotnet-module/default.nix:258:36:
257| else
258| ''$(mktemp -t "${finalAttrs.pname ? finalAttrs.finalPackage.name}-deps-XXXXXX.nix")'';
| ^
259| nugetToNix = (nuget-to-nix.override { inherit dotnet-sdk; });
error: cannot coerce a Boolean to a string: false
Switch from `?` operator (attribute presence predicate) to an `or`
("else" form).
13 tasks
MattSturgeon
approved these changes
Sep 13, 2024
ofborg
bot
added
10.rebuild-darwin: 0
tie
approved these changes
Sep 13, 2024
Contributor
|
I wonder if this should be using |
Contributor
I had the same thought initially, but it looked like it was doing something custom? |
Contributor
Nah, I just wanted it to have the package name in there. Come to think of it, it probably should just use the package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the change the eval fails as:
Switch from
?operator (attribute presence predicate) to anor("else" form).Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.