Skip to content

cargo-vendor-bin: init at 0.1.13#34082

Closed
zimbatm wants to merge 1 commit intoNixOS:masterfrom
zimbatm:cargo-vendor-bin-0.1.13
Closed

cargo-vendor-bin: init at 0.1.13#34082
zimbatm wants to merge 1 commit intoNixOS:masterfrom
zimbatm:cargo-vendor-bin-0.1.13

Conversation

@zimbatm
Copy link
Member

@zimbatm zimbatm commented Jan 20, 2018 •
edited
Loading

Motivation for this change

Unroll the rust bootstrap phase. By moving cargo-vendor to the top-level it makes it easier to update it or override in overlays.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@zimbatm
Copy link
Member Author

zimbatm commented Jan 20, 2018

@GrahamcOfBorg build cargo-vendor-bin

GrahamcOfBorg
GrahamcOfBorg reviewed Jan 20, 2018
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  2 4516k    2 97964    0     0  97964      0  0:00:47 --:--:--  0:00:47  247k
 29 4516k   29 1349k    0     0  1349k      0  0:00:03  0:00:01  0:00:02  963k
100 4516k  100 4516k    0     0  2258k      0  0:00:02  0:00:02 --:--:-- 1911k

building path(s) ‘/nix/store/k50p7zd2l4is5xqamyi8mga5jfxhsrlr-cargo-vendor-bin-0.1.13’
unpacking sources
unpacking source archive /nix/store/8xhvbchmyl03shrxqx9g4jwd1j4c9gqv-cargo-vendor-0.1.13-x86_64-unknown-linux-musl.tar.gz
source root is cargo-vendor-0.1.13-x86_64-unknown-linux-musl
setting SOURCE_DATE_EPOCH to timestamp 1509986910 of file cargo-vendor-0.1.13-x86_64-unknown-linux-musl/cargo-vendor
installing
/nix/store/k50p7zd2l4is5xqamyi8mga5jfxhsrlr-cargo-vendor-bin-0.1.13

GrahamcOfBorg
GrahamcOfBorg reviewed Jan 20, 2018
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

these paths will be fetched (2.69 MiB download, 2.71 MiB unpacked):
  /nix/store/nfnb65r2a4k9xmy8ndfpysfsj3b2mfa4-cargo-vendor-0.1.13-x86_64-apple-darwin.tar.gz
copying path '/nix/store/nfnb65r2a4k9xmy8ndfpysfsj3b2mfa4-cargo-vendor-0.1.13-x86_64-apple-darwin.tar.gz' from 'https://cache.nixos.org'...
building '/nix/store/457vgapvyz7783vz74vmb715jz9x03gf-cargo-vendor-bin-0.1.13.drv'...
unpacking sources
unpacking source archive /nix/store/nfnb65r2a4k9xmy8ndfpysfsj3b2mfa4-cargo-vendor-0.1.13-x86_64-apple-darwin.tar.gz
source root is cargo-vendor-0.1.13-x86_64-apple-darwin
setting SOURCE_DATE_EPOCH to timestamp 1510013565 of file cargo-vendor-0.1.13-x86_64-apple-darwin/cargo-vendor
installing
/nix/store/jrlzfzx0l7sl8l2s5gig5ns2xrzggzpz-cargo-vendor-bin-0.1.13

GrahamcOfBorg
GrahamcOfBorg reviewed Jan 20, 2018
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

error: while evaluating the attribute 'src' of the derivation 'cargo-vendor-bin-0.1.13' at /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/pkgs/stdenv/generic/make-derivation.nix:148:11:
while evaluating anonymous function at /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/pkgs/build-support/fetchurl/default.nix:38:1, called from /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/pkgs/tools/package-management/cargo-vendor-bin/default.nix:24:9:
missing bootstrap hash for platform aarch64-linux

@zimbatm zimbatm force-pushed the cargo-vendor-bin-0.1.13 branch from d4b2a81 to 7de4510 Compare January 20, 2018 15:25
@zimbatm
Copy link
Member Author

zimbatm commented Jan 20, 2018

fixed meta.platforms. There is no release for aarch64.

@GrahamcOfBorg build cargo-vendor-bin

GrahamcOfBorg
GrahamcOfBorg reviewed Jan 20, 2018
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

/nix/store/jrlzfzx0l7sl8l2s5gig5ns2xrzggzpz-cargo-vendor-bin-0.1.13

GrahamcOfBorg
GrahamcOfBorg reviewed Jan 20, 2018
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 10684  100 10684    0     0  10684      0  0:00:01 --:--:--  0:00:01 55645

building path(s) ‘/nix/store/k50p7zd2l4is5xqamyi8mga5jfxhsrlr-cargo-vendor-bin-0.1.13’
unpacking sources
unpacking source archive /nix/store/8xhvbchmyl03shrxqx9g4jwd1j4c9gqv-cargo-vendor-0.1.13-x86_64-unknown-linux-musl.tar.gz
source root is cargo-vendor-0.1.13-x86_64-unknown-linux-musl
setting SOURCE_DATE_EPOCH to timestamp 1509986910 of file cargo-vendor-0.1.13-x86_64-unknown-linux-musl/cargo-vendor
installing
/nix/store/k50p7zd2l4is5xqamyi8mga5jfxhsrlr-cargo-vendor-bin-0.1.13

GrahamcOfBorg
GrahamcOfBorg reviewed Jan 20, 2018
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

Package ‘cargo-vendor-bin-0.1.13’ in /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/tools/package-management/cargo-vendor-bin/default.nix:36 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@zimbatm zimbatm mentioned this pull request Jan 20, 2018
Closed
@Mic92
Copy link
Member

Mic92 commented Jan 21, 2018

I actually planned to merge #33980 instead.

@LnL7
Copy link
Member

LnL7 commented Jan 21, 2018

FYI. The meta check is failing, it's meta.license.

@Mic92 Sure.

@zimbatm
Copy link
Member Author

zimbatm commented Jan 21, 2018

sounds good. closing in favor of #33980

@zimbatm zimbatm closed this Jan 21, 2018
@zimbatm zimbatm deleted the cargo-vendor-bin-0.1.13 branch January 21, 2018 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@GrahamcOfBorg GrahamcOfBorg GrahamcOfBorg left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zimbatm @Mic92 @LnL7 @GrahamcOfBorg