dotnetCorePackages.fetchNupkg: override avalonia to include upstream fix#340493
Merged
NickCao merged 1 commit intoNixOS:masterfrom Sep 8, 2024
Merged
dotnetCorePackages.fetchNupkg: override avalonia to include upstream fix#340493NickCao merged 1 commit intoNixOS:masterfrom
NickCao merged 1 commit intoNixOS:masterfrom
Conversation
20 tasks
ofborg
bot
added
10.rebuild-darwin: 0
Contributor
|
Result of 1 package built:
|
Backport AvaloniaUI/Avalonia#16835 to versions 11.1.0 through 11.2.0-beta1 Co-authored-by: Nick Cao <[email protected]>
MattSturgeon
force-pushed
the
avalonia-11.1-fix
branch
from
808d528 to
c8a0f01
Compare
corngood
approved these changes
Sep 8, 2024
Contributor
corngood
left a comment
corngood
left a comment
There was a problem hiding this comment.
I confirmed that this fixes retrospy. Thanks!
This was referenced Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Backport AvaloniaUI/Avalonia#16835 to versions 11.1.0 through 11.2.0-beta1
These versions have a runtime error when built with
dotnet publish --no-build. When attempting to draw a window, Avalonia will throw "No precompiled XAML found".Upstream
Packages affected
retrospysince retrospy: 6.5 -> 6.6 #338143nexusmods-app; has been blocking nexusmods-app: 0.4.1 -> 0.6.1 #331150AFAICT these are the only affected packages in nixpkgs, but I included the list of affected release versions anyway to avoid regressions when updating other packages and to aid anyone using nixpkg's dotnet built-support functions outside of nixpkgs.
See #331150 (comment) where this was originally discussed.
cc @corngood @Naxdy @NickCao
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.