Skip to content

python312: 3.12.5 -> 3.12.6; python311: 3.11.9 -> 3.11.10#340252

Merged
natsukium merged 2 commits intoNixOS:stagingfrom
mweinelt:python-3.12.6
Sep 8, 2024
Merged

python312: 3.12.5 -> 3.12.6; python311: 3.11.9 -> 3.11.10#340252
natsukium merged 2 commits intoNixOS:stagingfrom
mweinelt:python-3.12.6

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Sep 7, 2024 •
edited by natsukium
Loading

https://docs.python.org/release/3.12.6/whatsnew/changelog.html
https://docs.python.org/release/3.11.10/whatsnew/changelog.html

Closes: #340246

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@mweinelt mweinelt requested a review from natsukium as a code owner September 7, 2024 04:04
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Sep 7, 2024
@mweinelt mweinelt changed the title python312: 3.12.5 -> 3.12.6 python312: 3.12.5 -> 3.12.6; python311: 3.11.9 -> 3.11.0 Sep 7, 2024
@mweinelt mweinelt added backport staging-24.05 1.severity: security Issues which raise a security issue, or PRs that fix one labels Sep 7, 2024
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Sep 7, 2024
@mweinelt mweinelt changed the title python312: 3.12.5 -> 3.12.6; python311: 3.11.9 -> 3.11.0 python312: 3.12.5 -> 3.12.6; python311: 3.11.9 -> 3.11.10 Sep 7, 2024
natsukium
natsukium approved these changes Sep 8, 2024
View reviewed changes
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on all four major platforms

@natsukium natsukium merged commit 4ebf78a into NixOS:staging Sep 8, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2024

Backport failed for staging-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin staging-24.05
git worktree add -d .worktree/backport-340252-to-staging-24.05 origin/staging-24.05
cd .worktree/backport-340252-to-staging-24.05
git switch --create backport-340252-to-staging-24.05
git cherry-pick -x 9550eb8922a4ff28fcdc14b32bd28553d050dd8c a161af2daadfd38583ee45ed4b200ca21617fb74

@mweinelt mweinelt deleted the python-3.12.6 branch September 8, 2024 02:23
@mweinelt mweinelt mentioned this pull request Sep 8, 2024
Merged
13 tasks
@trofi
Copy link
Contributor

trofi commented Sep 8, 2024

Bisect claims that 9550eb8 python312: 3.12.5 -> 3.12.6 broke python3Packages.poetry-core in staging as:

$ nix build --no-link github:NixOS/nixpkgs/staging#python3Packages.poetry-core -L
...
python3.12-poetry-core> tests/version/test_requirements.py ...........................F.         [100%]
python3.12-poetry-core> =================================== FAILURES ===================================
python3.12-poetry-core> _____________ test_invalid_requirement[name @ file:.-invalid URL] ______________
python3.12-poetry-core> string = 'name @ file:.', exception = 'invalid URL'
python3.12-poetry-core>     @pytest.mark.parametrize(
python3.12-poetry-core>         ["string", "exception"],
python3.12-poetry-core>         [
python3.12-poetry-core>             ("foo!", "Unexpected character at column 4\n\nfoo!\n   ^\n"),
python3.12-poetry-core>             ("foo (>=bar)", 'invalid version constraint ">=bar"'),
python3.12-poetry-core>             ("name @ file:.", "invalid URL"),
python3.12-poetry-core>             ("name @ file:/.", "invalid URL"),
python3.12-poetry-core>         ],
python3.12-poetry-core>     )
python3.12-poetry-core>     def test_invalid_requirement(string: str, exception: str) -> None:
python3.12-poetry-core> >       with pytest.raises(
python3.12-poetry-core>             InvalidRequirement,
python3.12-poetry-core>             match=re.escape(f"The requirement is invalid: {exception}"),
python3.12-poetry-core>         ):
python3.12-poetry-core> E       Failed: DID NOT RAISE <class 'poetry.core.version.requirements.InvalidRequirement'>
python3.12-poetry-core> tests/version/test_requirements.py:130: Failed
python3.12-poetry-core> =========================== short test summary info ============================
python3.12-poetry-core> FAILED tests/version/test_requirements.py::test_invalid_requirement[name @ file:.-invalid URL] - Failed: DID NOT RAISE <class 'poetry.core.version.requirements.InvalidRequi...
python3.12-poetry-core> ========== 1 failed, 2035 passed, 3 skipped, 11 deselected in 14.51s ===========

@mweinelt
Copy link
Member Author

mweinelt commented Sep 9, 2024

Reported upstream in python-poetry/poetry#9678

@alyssais
Copy link
Member

alyssais commented Sep 13, 2024

#341584

@alyssais
Copy link
Member

alyssais commented Sep 14, 2024

Also twisted: twisted/twisted#12314

@alyssais
Copy link
Member

alyssais commented Sep 14, 2024

executing: alexmojaki/executing#85

@alyssais alyssais mentioned this pull request Sep 15, 2024
Open
13 tasks
@alyssais
Copy link
Member

alyssais commented Sep 16, 2024

Fix for twisted: #342331

@alyssais
Copy link
Member

alyssais commented Sep 16, 2024

Fix for executing: #342333

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Sep 16, 2024

Thanks for the fixes!

@raboof raboof mentioned this pull request Oct 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@natsukium natsukium natsukium approved these changes

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mweinelt @trofi @alyssais @SuperSandro2000 @natsukium