overrideSDK: fix on aarch64-darwin#340131
Merged
philiptaron merged 1 commit intoNixOS:masterfrom Sep 6, 2024
Merged
Conversation
I don’t want to talk about it. Fixes QEMU.
ofborg
bot
added
6.topic: darwin
philiptaron
approved these changes
Sep 6, 2024
Contributor
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
I'm going to take your word (and that of the Matrix channel) on this.
13 tasks
emilazy
added a commit
to emilazy/nixpkgs
that referenced
this pull request
Sep 7, 2024
Thanks to <NixOS#340131>, this now works, and we no longer need to vendor the patch.
alyssais
pushed a commit
that referenced
this pull request
Sep 16, 2024
Thanks to <#340131>, this now works, and we no longer need to vendor the patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
I don’t want to talk about it.
Fixes QEMU.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.