vulkan-headers: build using ninja to fix gcc-14 compatibility#340013
Closed
trofi wants to merge 1 commit intoNixOS:stagingfrom
Closed
vulkan-headers: build using ninja to fix gcc-14 compatibility#340013trofi wants to merge 1 commit intoNixOS:stagingfrom
gcc-14 compatibility#340013trofi wants to merge 1 commit intoNixOS:stagingfrom
Conversation
ofborg
bot
added
10.rebuild-darwin: 101-500
Ralith
approved these changes
Sep 6, 2024
Contributor
Ralith
left a comment
Ralith
left a comment
There was a problem hiding this comment.
Seems reasonable. Maybe leave a comment explaining why we're diverging from the minimal approach?
When `vulkan-headers` detects `gcc-14` or above it enables c++ modules
support. But make-mased backend does not support it and fails as:
$ nix build --impure --expr 'with import ./. {}; vulkan-headers.override {stdenv = gcc14Stdenv; }' -L
CMake Error in CMakeLists.txt:
The target named "Vulkan-Module" has C++ sources that may use modules, but
modules are not supported by this generator:
Unix Makefiles
Modules are supported only by Ninja, Ninja Multi-Config, and Visual Studio
generators for VS 17.4 and newer. See the cmake-cxxmodules(7) manual for
details. Use the CMAKE_CXX_SCAN_FOR_MODULES variable to enable or disable
scanning.
trofi
force-pushed
the
vulkan-headers-gcc-14-fix
branch
from
ae633e4 to
9e0e1cf
Compare
Contributor
Author
|
Added the comment + # Adding `ninja` here to enable Ninja backend. Otherwise on gcc-14 or
+ # later the build fails as:
+ # modules are not supported by this generator: Unix Makefiles |
Ralith
approved these changes
Sep 7, 2024
wegank
added
12.approvals: 1
Member
|
*-darwin suffers from this issue on the current staging-next already. |
Member
|
But the darwin build seems bad anyway. If I add ninja locally, it fails on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
vulkan-headersdetectsgcc-14or above it enables c++ modules support. But make-mased backend does not support it and fails as:Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.