Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

music-player: fix build #339972

Merged
merged 3 commits into from
Sep 6, 2024
Merged

music-player: fix build #339972

merged 3 commits into from
Sep 6, 2024

Conversation

ocfox
Copy link
Member

@ocfox ocfox commented Sep 6, 2024

Description of changes

Fix build broken by rust 1.80

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Aleksanaa
Copy link
Member

Please split moving and formatting into separate commits. Git will not be able to track moved files in this manner.

Aleksanaa
Aleksanaa reviewed Sep 6, 2024
View reviewed changes
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split formatting into a separate commit.

ocfox added 2 commits September 6, 2024 21:34
@ocfox
music-player: 0.2.0-alpha.14 -> unstable-2024-08-24
1af6eaf 
update to 0.2.0-alpha.14-unstable-2024-08-24 to fix build
@ocfox
music-player: format
6350c71
@ocfox
Copy link
Member Author

ocfox commented Sep 6, 2024

Done.

@Aleksanaa Aleksanaa merged commit 0fd01c0 into NixOS:master Sep 6, 2024
8 of 9 checks passed
@ocfox ocfox deleted the music-player-fix branch September 6, 2024 13:46
@archer-65 archer-65 mentioned this pull request Oct 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ocfox @Aleksanaa