Skip to content

tzdata: 2024a -> 2024b#339913

Merged
fpletz merged 1 commit intoNixOS:stagingfrom
trofi:tzdata-update
Sep 7, 2024
Merged

tzdata: 2024a -> 2024b#339913
fpletz merged 1 commit intoNixOS:stagingfrom
trofi:tzdata-update

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Sep 5, 2024

Changes: https://github.com/eggert/tz/blob/2024b/NEWS

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. label Sep 5, 2024
@ofborg ofborg bot requested review from ajs124 and fpletz September 5, 2024 23:45
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Sep 5, 2024
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Sep 6, 2024
@fpletz fpletz merged commit 39ada1f into NixOS:staging Sep 7, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2024

Successfully created backport PR for staging-24.05:

@trofi trofi deleted the tzdata-update branch September 7, 2024 12:08
@emilazy
Copy link
Member

emilazy commented Sep 11, 2024

Looks like the build is broken? #340523 (comment)

@emilazy
Copy link
Member

emilazy commented Sep 11, 2024

Beautiful:

ccuurrlcl:u: r ((7777) err)o rle :rrosre tste titnign( g cert7ificate cfeirl7te) eirfriocr setti:ng certifi acate file: /n/no-certto--fcielret.cr-tf
ei file: /nloe.crt-
cert-file.crt
curl: (77) error setting certificate file: /no-cert-file.crt
clang -o date -DHAVE_LINK=0 -DZIC_BLOAT_DEFAULT=\"fat\"  date.o localtime.o strftime.o 
make: *** [Makefile:992: theory.ck] Error 1
make: *** Waiting for unfinished jobs....

(from #340523 (comment))

@gshpychka
Copy link
Contributor

Beautiful:

ccuurrlcl:u: r ((7777) err)o rle :rrosre tste titnign( g cert7ificate cfeirl7te) eirfriocr setti:ng certifi acate file: /n/no-certto--fcielret.cr-tf
ei file: /nloe.crt-
cert-file.crt
curl: (77) error setting certificate file: /no-cert-file.crt
clang -o date -DHAVE_LINK=0 -DZIC_BLOAT_DEFAULT=\"fat\"  date.o localtime.o strftime.o 
make: *** [Makefile:992: theory.ck] Error 1
make: *** Waiting for unfinished jobs....

(from #340523 (comment))

FWIW, here's my log, which is a bit clearer :)

curl: (77) error setting certificate file: /no-cert-file.crt
curl: (77) error setting certificate filcurl: (77) error setting certificate file: /no-cert-file.crt
curl: (77) e: /no-cert-file.crt
error setting certificate file: /no-cert-file.crt
make: *** [Makefile:992: tz-how-to.ck] Error 1
make: *** Waiting for unfinished jobs....

@emilazy
Copy link
Member

emilazy commented Sep 11, 2024

ccuurrlcl is experiencing an eirfriocr when setti:ng certifi acate file, what could be more clear?

@mweinelt
Copy link
Member

mweinelt commented Sep 11, 2024

@vcunat
Copy link
Member

vcunat commented Sep 11, 2024

@emilazy
Copy link
Member

emilazy commented Sep 11, 2024

I can’t immediately find a patch for one of the issues mentioned on the mailing list so perhaps we should roll back until the next release.

@mweinelt
Copy link
Member

Was reverted on staging-next-24.05 already.

@trofi
Copy link
Contributor Author

trofi commented Sep 11, 2024

The reported failure looks darwin-specific (curl presence in the build closure?). I'll see how easy it is to trick darwin not to run network tests.

@trofi
Copy link
Contributor Author

trofi commented Sep 12, 2024

The reported failure looks darwin-specific (curl presence in the build closure?). I'll see how easy it is to trick darwin not to run network tests.

Proposed the fix as:

@github-actions
Copy link
Contributor

Successfully created backport PR for staging-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants