freebsd: improve overridability of entire package set#339912
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Nov 25, 2024
Merged
freebsd: improve overridability of entire package set#339912Ericson2314 merged 1 commit intoNixOS:masterfrom
Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
wegank
added
the
2.status: merge conflict
rhelmot
force-pushed
the
freebsd-overridable
branch
2 times, most recently
from
07759db to
c8ebd00
Compare
Member
|
Could we do the Otherwise looks good. |
- remove duplicated patches directory attribute - make several version number checks >= or <= instead of == - add kernel derivation parameters to adjust build config
rhelmot
force-pushed
the
freebsd-overridable
branch
from
c8ebd00 to
c565ccd
Compare
Contributor
Author
|
done |
Ericson2314
approved these changes
Nov 19, 2024
wegank
added
the
12.approvals: 1
ofborg
bot
removed
the
2.status: merge conflict
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
See commit. Basically, this lets us use a simple overlay in order to build FreeBSD 15.0-CURRENT!
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.