Skip to content

gn: backport LFS64 cleanup#339794

Merged
alyssais merged 1 commit intoNixOS:stagingfrom
alyssais:gn-lfs64
Sep 13, 2024
Merged

gn: backport LFS64 cleanup#339794
alyssais merged 1 commit intoNixOS:stagingfrom
alyssais:gn-lfs64

Conversation

@alyssais
Copy link
Member

@alyssais alyssais commented Sep 5, 2024

Description of changes

This is required to build with musl 1.2.4 and later.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This is required to build with musl 1.2.4 and later.
@ofborg ofborg bot requested review from matthewbauer, primeos and stesie September 5, 2024 14:48
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Sep 5, 2024
@alyssais alyssais added the 6.topic: musl Running or building packages with musl libc label Sep 8, 2024
@alyssais alyssais merged commit fdbe69f into NixOS:staging Sep 13, 2024
@alyssais alyssais mentioned this pull request Sep 13, 2024
47 tasks
@alyssais alyssais deleted the gn-lfs64 branch September 13, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: musl Running or building packages with musl libc 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant