Skip to content

clps2c-compiler: init at 1.0.1#339716

Merged
corngood merged 1 commit intoNixOS:masterfrom
Gigahawk:clps2c-compiler
Nov 5, 2024
Merged

clps2c-compiler: init at 1.0.1#339716
corngood merged 1 commit intoNixOS:masterfrom
Gigahawk:clps2c-compiler

Conversation

@Gigahawk
Copy link
Contributor

@Gigahawk Gigahawk commented Sep 5, 2024 •
edited by corngood
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Gigahawk Gigahawk requested a review from corngood as a code owner September 5, 2024 05:51
@github-actions github-actions bot added the 6.topic: dotnet Language: .NET label Sep 5, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Sep 5, 2024
@corngood corngood mentioned this pull request Sep 13, 2024
Merged
13 tasks
@github-actions github-actions bot removed the 6.topic: dotnet Language: .NET label Sep 17, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Sep 17, 2024
FliegendeWurst
FliegendeWurst requested changes Nov 3, 2024
View reviewed changes
@corngood
Copy link
Contributor

corngood commented Nov 3, 2024

@Gigahawk could you squash the second commit into the first?

@Gigahawk
Copy link
Contributor Author

Gigahawk commented Nov 4, 2024

@Gigahawk could you squash the second commit into the first?

Sorry yea I had meant to do that but pulling the new commit was taking a while and I had to step away. I'll try to get it done tonight

@github-actions github-actions bot added 8.has: documentation This PR adds or changes documentation 6.topic: dotnet Language: .NET labels Nov 4, 2024
@github-actions github-actions bot removed 8.has: documentation This PR adds or changes documentation 6.topic: dotnet Language: .NET labels Nov 4, 2024
@corngood
Copy link
Contributor

corngood commented Nov 5, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 339716

x86_64-linux

✅ 1 package built:
  • clps2c-compiler

corngood
corngood approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@corngood corngood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@corngood corngood merged commit 75c9076 into NixOS:master Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corngood corngood corngood approved these changes

@FliegendeWurst FliegendeWurst Awaiting requested review from FliegendeWurst

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Gigahawk @corngood @FliegendeWurst