Skip to content

nodejs_22: 22.7.0 -> 22.8.0#339252

Merged
emilazy merged 1 commit intoNixOS:staging-nextfrom
aduh95:patch-1
Sep 6, 2024
Merged

nodejs_22: 22.7.0 -> 22.8.0#339252
emilazy merged 1 commit intoNixOS:staging-nextfrom
aduh95:patch-1

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 3, 2024

Description of changes

https://github.com/nodejs/node/releases/tag/v22.8.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment label Sep 3, 2024
@emilazy
Copy link
Member

emilazy commented Sep 3, 2024

Building on aarch64-linux and aarch64-darwin.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 3, 2024
@emilazy
Copy link
Member

emilazy commented Sep 3, 2024

Can you rebase/retarget this to staging-next? We shouldn’t wait several more weeks to avoid shipping a known‐broken Node.js and it’d make testing the builds a lot faster.

@aduh95 aduh95 changed the base branch from staging to staging-next September 3, 2024 16:45
@emilazy
Copy link
Member

emilazy commented Sep 6, 2024

Whoops, I forgot about this one. Double‐checking the build on Darwin.

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It builds. Already checked Linux earlier.

@emilazy emilazy merged commit 7f3e4cc into NixOS:staging-next Sep 6, 2024
@aduh95 aduh95 deleted the patch-1 branch September 6, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants