Skip to content

hydra: 0-unstable-2024-09-15 -> 0-unstable-2024-09-20#338902

Merged
NickCao merged 2 commits intoNixOS:masterfrom
qowoz:hydra
Sep 20, 2024
Merged

hydra: 0-unstable-2024-09-15 -> 0-unstable-2024-09-20#338902
NickCao merged 2 commits intoNixOS:masterfrom
qowoz:hydra

Conversation

@zowoq
Copy link
Contributor

@zowoq zowoq commented Sep 1, 2024

follow up from 0c454e9

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 1, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 2, 2024
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zowoq zowoq marked this pull request as draft September 20, 2024 07:36
@zowoq zowoq changed the title nixos/hydra: set a default for hydra-compress-logs service hydra: 0-unstable-2024-09-15 -> 0-unstable-2024-09-20 Sep 20, 2024
@zowoq
Copy link
Contributor Author

zowoq commented Sep 20, 2024

Shall we submit this upstream first?

NixOS/hydra@b472f55

@zowoq zowoq marked this pull request as ready for review September 20, 2024 07:38
@ofborg ofborg bot requested review from Conni2461, Mindavi and dasJ September 20, 2024 08:12
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NickCao NickCao merged commit a1d9266 into NixOS:master Sep 20, 2024
@zowoq zowoq deleted the hydra branch September 20, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants