Skip to content

grpc: 1.62.1 -> 1.66.1#338875

Merged
nikstur merged 3 commits intoNixOS:stagingfrom
rorosen:update-grpc
Sep 5, 2024
Merged

grpc: 1.62.1 -> 1.66.1#338875
nikstur merged 3 commits intoNixOS:stagingfrom
rorosen:update-grpc

Conversation

@rorosen
Copy link
Contributor

@rorosen rorosen commented Sep 1, 2024

Description of changes

I messed up in the initial PR and caused a mass ping. This is a new try.

This updates grpc and related python packages.

grpc: 1.62.1 -> 1.66.1

Diff: grpc/grpc@v1.62.1...v1.66.1

Changelog: https://github.com/grpc/grpc/releases/tag/v1.66.1

python3Packages.grpcio-status: 1.64.1 -> 1.66.1

python3Packages.grpcio-tools: 1.64.1 -> 1.66.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Sep 1, 2024
@rorosen rorosen requested review from LnL7 and mweinelt September 1, 2024 19:16
@rorosen
Copy link
Contributor Author

rorosen commented Sep 1, 2024

ping @risicle @nikstur

@rorosen rorosen added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Sep 1, 2024
drupol
drupol approved these changes Sep 1, 2024
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

drupol
drupol reviewed Sep 1, 2024
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR title accordingly.

@rorosen rorosen changed the title Update grpc grpc: 1.62.1 -> 1.66.1 Sep 1, 2024
@risicle
Copy link
Contributor

risicle commented Sep 1, 2024

I can confirm the two lines mentioned in grpc/grpc#36654 (comment) added to the toplevel CMakeLists.txt fix build on macos 12 x86_64.

Whether it's preferred to use a patch to add them, append them using cat or whatever is up you and/or the maintainers.

@ofborg ofborg bot requested a review from fabaff September 1, 2024 21:48
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Sep 1, 2024
@risicle risicle mentioned this pull request Sep 1, 2024
Merged
13 tasks
@rorosen
Copy link
Contributor Author

rorosen commented Sep 2, 2024

I can confirm the two lines mentioned in grpc/grpc#36654 (comment) added to the toplevel CMakeLists.txt fix build on macos 12 x86_64.

Build on x86_64-darwin fails now due to timeout. Not sure what to do about it...

@risicle
Copy link
Contributor

risicle commented Sep 2, 2024

Not because of grpc though, because some change to llvm. I generally don't expect ofborg builds to be successful on the staging branch.

@nikstur nikstur merged commit 41cab8f into NixOS:staging Sep 5, 2024
@rorosen rorosen deleted the update-grpc branch September 5, 2024 13:40
@matdibu
Copy link
Contributor

matdibu commented Oct 16, 2024

you forgot python312Packages.grpcio, it's sitting at 1.64.1
this, unfortunately, makes it incompatible with grpcio-tools
so files generated with grpcio-tools 1.66 cannot be used by grpcio 1.64

@rorosen
Copy link
Contributor Author

rorosen commented Oct 16, 2024 •
edited
Loading

I'm very sorry to hear that. I'm not aware of what python packages needs to be updated with grpc. I see that there is already a PR (#346850) that updates python312Packages.grpcio, however, I will open a PR that extends the comment of packages that should always be updated with grpc.

Edit: Added in #349050

@rorosen rorosen mentioned this pull request Oct 16, 2024
Merged
13 tasks
@matdibu
Copy link
Contributor

matdibu commented Oct 16, 2024

fair enough, it wasn't mentioned there and there aren't any tests that would've caught that

@scraptux scraptux mentioned this pull request Oct 22, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drupol drupol drupol approved these changes

@mweinelt mweinelt Awaiting requested review from mweinelt

@LnL7 LnL7 Awaiting requested review from LnL7

@fabaff fabaff Awaiting requested review from fabaff

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rorosen @risicle @matdibu @drupol @nikstur