Skip to content

sonarr: 4.0.8.1874 -> 4.0.9.2244#338719

Merged
tie merged 1 commit intoNixOS:masterfrom
devusb:sonarr
Sep 3, 2024
Merged

sonarr: 4.0.8.1874 -> 4.0.9.2244#338719
tie merged 1 commit intoNixOS:masterfrom
devusb:sonarr

Conversation

@devusb
Copy link
Contributor

@devusb devusb commented Sep 1, 2024

Description of changes

Sonarr/Sonarr@v4.0.8.1874...v4.0.9.2244

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from purcell and tie September 1, 2024 02:54
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 1, 2024
@tie
Copy link
Member

tie commented Sep 2, 2024

Hm, how did you generate this update? I’ve run updateScript and fetch-deps step gets stuck after #327651 or perhaps some other recent .NET build infrastructure change (or perhaps my patience runs out after ~10 minutes).

@devusb
Copy link
Contributor Author

devusb commented Sep 2, 2024 •
edited
Loading

@tie I just ran the updateScript locally as

nix-shell maintainers/scripts/update.nix --argstr package sonarr

It did take awhile, maybe ~10 mins -- I walked away while it ran.

FWIW I checked the bot logs before opening the PR -- looks like it's trying to run the script, but I assume it's also timing out.

tie
tie approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@tie tie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, reproduced the hashes after refactoring updateScript to avoid running nix build for fetch-deps. I plan to merge this PR in the evening, thank you!

Current updateScript does indeed complete, but takes >10m which is a bit more than I could tolerate 😅

@tie tie mentioned this pull request Sep 3, 2024
Open
13 tasks
@tie tie merged commit d52e321 into NixOS:master Sep 3, 2024
@devusb devusb deleted the sonarr branch September 3, 2024 17:51
@tie tie mentioned this pull request Sep 9, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tie tie tie approved these changes

@purcell purcell Awaiting requested review from purcell

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devusb @tie