treewide: remove refs/tags/ from github release meta.changelog urls#338301
treewide: remove refs/tags/ from github release meta.changelog urls#338301natsukium merged 1 commit intoNixOS:masterfrom
refs/tags/ from github release meta.changelog urls#338301Conversation
diff of `jq <packages.json 'to_entries[]|"\(.key) \(.value.meta.changelog)"' -r`: https://gist.github.com/pbsds/49b2e2ae5c9b967a0972bbc3c2597c12
emilazy
left a comment
There was a problem hiding this comment.
Wish we had an API for constructing structured GitHub links, but LGTM.
I still wish we had any idea whether anyone is looking at these URLs ever. The fact that this many were broken and no user noticed suggests no.
|
I check them quite often, it should be encouraged rather than discouraged IMO |
|
Thank you for making your script public in this PR and others, Peder (@pbsds). I learn so much from these "worked demonstrations". It's really appreciated. |
|
Since they are computed values, I wonder if they couldn't be automated away in 90% of the cases. Not a blocker for this PR, but more as a follow-up conversation (see #338366). |
|
Hmmm. I wonder if we could abstract this with a It would be mutually exclusive with |
|
I strongly support a |
natsukium
left a comment
There was a problem hiding this comment.
I think it used to work fine, but now it does not.
Thanks for your work.
|
What's the point of this change? Is making the URLs a little nicer worth it? |
diff of
jq <packages.json 'to_entries[]|"\(.key) \(.value.meta.changelog)"' -r:https://gist.github.com/pbsds/49b2e2ae5c9b967a0972bbc3c2597c12
Description of changes
the majority of this pr was made using:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.