hydra: 2024-08-20 -> 0-unstable-2024-08-27 #338097
Conversation
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
8.has: clean-up
ofborg
bot
added
10.rebuild-darwin: 1-10
pkgs/by-name/hy/hydra/package.nix
Outdated
There was a problem hiding this comment.
It would be nice if we could still override nix, sometimes I use an overlay to quickly verify some hydra patches and it could happen that nix also needed overriding then. Of course nixVersions.nix_2_22 = nixVersions.nix_2_24 might work, but it doesn't feel great...
Not the highest priority, we can let it go if we don't find a satisfactory solution.
There was a problem hiding this comment.
Yeah, better to keep that around. Still using all-packages seems to be fine according to the docs.
nixpkgs/pkgs/by-name/README.md
Lines 68 to 69 in 3c7d6a1
nixpkgs/pkgs/by-name/README.md
Line 92 in 3c7d6a1
Mindavi
left a comment
Mindavi
left a comment
There was a problem hiding this comment.
One thing, but I don't want to block on that.
|
Even better, thanks |
| '' | ||
| find /var/lib/hydra/build-logs -type f -name "*.drv" -mtime +3 -size +0c | xargs -r bzip2 -v -f | ||
| set -eou pipefail | ||
| compression=$(sed -nr 's/compress_build_logs_compression = ()/\1/p' ${baseDir}/hydra.conf) |
There was a problem hiding this comment.
We need a default value when compress_build_logs_compression is not configured.
The entry in `all-packages.nix` was left in while moving to `by-name` with a [reference to the docs]. This recommendation had [since changed] and this commit aligns the expression with the new recommendation. [reference to the docs]: #338097 (comment) [since changed]: 4664ae4
The entry in `all-packages.nix` was left in while moving to `by-name` with a [reference to the docs]. This recommendation had [since changed] and this commit aligns the expression with the new recommendation. [reference to the docs]: NixOS#338097 (comment) [since changed]: NixOS@4664ae4
4 participants
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.