Skip to content

maintainers: remove superherointj#337552

Merged
emilazy merged 1 commit intoNixOS:masterfrom
superherointj:superherointj-leave-nixpkgs
Aug 27, 2024
Merged

maintainers: remove superherointj#337552
emilazy merged 1 commit intoNixOS:masterfrom
superherointj:superherointj-leave-nixpkgs

Conversation

@superherointj
Copy link
Contributor

@superherointj superherointj commented Aug 26, 2024

I'm sorry. But I no longer have the health/energy/time/sanity for this.

Thanks for the kindness.

Best regards.

Pending

@github-actions github-actions bot added 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: k3s Kubernates distribution (https://k3s.io/) labels Aug 26, 2024
@superherointj superherointj force-pushed the superherointj-leave-nixpkgs branch from ccb483a to 7354bda Compare August 26, 2024 20:51
@superherointj superherointj changed the title remove superherointj from maintainers maintainers: remove superherointj Aug 26, 2024
@superherointj superherointj requested a review from Mic92 August 26, 2024 21:25
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 26, 2024
@superherointj superherointj requested a review from emilazy August 27, 2024 00:01
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions to the project. Sorry to see you go.

@emilazy emilazy merged commit 1faba3c into NixOS:master Aug 27, 2024
@superherointj superherointj deleted the superherointj-leave-nixpkgs branch August 27, 2024 00:08
@superherointj
Copy link
Contributor Author

@emilazy Thanks for the merge.

To merge code, you need to be a committer, or use the merge-bot, but currently the merge-bot only works for packages located at `pkgs/by-name/`, which means, K3s still need to be migrated there before you can use merge-bot for merging. As a non-committer, once you have approved a PR you need to forward the request to a committer. For deciding which committer, give preference initially to K3s committers, but any committer can commit. A committer usually has a green approval in PRs.

K3s's committers currently are: superherointj, marcusramberg, Mic92.
K3s's committers currently are: marcusramberg, Mic92.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcusramberg You are still interested in maintaining k3s? I am still considering myself more of a part-time user.

Copy link
Contributor

@marcusramberg marcusramberg Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mic92 I'm kinda in the same boat, I just run a single node cluster on my desktop at the moment, accepted to join this to spread the load, so I'm not super eager to be the main driver ;-)

Really sorry to see you go, @superherointj - thanks for all the contributions.

@emilazy
Copy link
Member

emilazy commented Aug 27, 2024

@Mic92 Are you able to handle moving from committers to the retired contributors team, as requested in the PR message?

@Mic92
Copy link
Member

Mic92 commented Aug 27, 2024

I removed him from the committers team, but I cannot manage the retired contributors team yet. I will ask for access.

@Mic92
Copy link
Member

Mic92 commented Aug 27, 2024

Invite sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: k3s Kubernates distribution (https://k3s.io/) 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants