tests.stdenv: Easier to override stdenv#336837
Open
Artturin wants to merge 1 commit intoNixOS:masterfrom
Open
Conversation
also getting rid of `pkgsStructuredAttrs` because tests for the whole `structuredAttrs` dependency tree don't belong here and should be split in to a different test.
Member
Author
|
Rebased to staging-next because there were incoming conflicts |
Artturin
force-pushed
the
teststdenvhookesieroverriding
branch
from
327aa01 to
76d0f11
Compare
ofborg
bot
added
10.rebuild-darwin: 0
4 tasks
Member
Author
|
@ofborg build tests.stdenv |
Artturin
commented
Oct 21, 2024
| bootStdenv = stdenv.__bootPackages.stdenv.__bootPackages.stdenv.__bootPackages.stdenv.__bootPackages.stdenv; | ||
| pkgsStructured = import pkgs.path { config = { structuredAttrsByDefault = true; }; inherit (stdenv.hostPlatform) system; }; | ||
| bootStdenvStructuredAttrsByDefault = pkgsStructured.stdenv.__bootPackages.stdenv.__bootPackages.stdenv.__bootPackages.stdenv.__bootPackages.stdenv; | ||
| bootStdenv = if stdenvHasBootPackages then stdenv.__bootPackages.stdenv.__bootPackages.stdenv.__bootPackages.stdenv.__bootPackages.stdenv else stdenv; |
Member
Author
There was a problem hiding this comment.
Seaprate pr should make it so we use longestValidPathPrefix and attrByPath here to support darwin
wegank
added
the
2.status: merge conflict
nixpkgs-ci
bot
added
the
2.status: stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also getting rid of
pkgsStructuredAttrsbecause tests for the wholestructuredAttrsdependency tree don't belong here and should be splitin to a different test.