Skip to content

[release-24.05]: backport nix code owner#336734

Merged
Mic92 merged 3 commits intoNixOS:release-24.05from
Mic92:codeowner-backport
Sep 10, 2024
Merged

[release-24.05]: backport nix code owner#336734
Mic92 merged 3 commits intoNixOS:release-24.05from
Mic92:codeowner-backport

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 23, 2024

Description of changes

So that the nix core team also get notified about backports.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Ma27 and others added 3 commits August 23, 2024 11:09
Using Lix now 🍦

(cherry picked from commit 7baa302)
I have no further plan to review CppNix code anymore as I will dedicate
myself to Lix development.

Co-authored-by: aleksana <[email protected]>
(cherry picked from commit bf7ddf8)
Update .github/CODEOWNERS

Co-authored-by: Robert Hensing <[email protected]>
(cherry picked from commit b6c51f7)
@github-actions github-actions bot added the 6.topic: policy discussion Discuss policies to work in and around Nixpkgs label Aug 23, 2024
@Mic92 Mic92 mentioned this pull request Aug 23, 2024
13 tasks
@Mic92
Copy link
Member Author

Mic92 commented Aug 23, 2024

Result of nixpkgs-review pr 336734 run on aarch64-darwin 1

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 23, 2024
@phanirithvij phanirithvij mentioned this pull request Sep 3, 2024
13 tasks
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 4, 2024
@Mic92 Mic92 merged commit e775ab7 into NixOS:release-24.05 Sep 10, 2024
@Mic92 Mic92 deleted the codeowner-backport branch January 18, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: policy discussion Discuss policies to work in and around Nixpkgs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants