Merged
Conversation
github-actions
bot
added
the
6.topic: nodejs
ofborg
bot
added
11.by: package-maintainer
Conni2461
approved these changes
Aug 23, 2024
13 tasks
aduh95
added a commit
to aduh95/nixpkgs
that referenced
this pull request
Sep 6, 2024
(cherry picked from commit 45db1ff)
dasJ
pushed a commit
that referenced
this pull request
Sep 13, 2024
* nodejs_18: pin to Python 3.11, fix tests with OpenSSL 3.0.14 (cherry picked from commit 7c1177c) * nodejs: use upstream patch instead of custom one (cherry picked from commit f75d503) * nodejs_22: 22.4.1 -> 22.5.1 (cherry picked from commit 070791f) * nodejs: use .finalPackage for ease of overriding Previously, the nodejs `passthru.pkgs` attribute refers to the package fixed point derived in the current context, without considering potential overrides to the main nodejs package. This is fixed here with the `.finalPackage` attribute, which refers to the final package fixed point, after potential overrides. For example, previously, after overriding nodejs with `nodejs.override`, `nodejs.pkgs` would still refer to the original package, instead of the overridden one. After this fix, `nodejs.pkgs` would be correctly based on the overridden `nodejs` package. (cherry picked from commit ee9a623) * nodejs: fix tests and disable parallel checking (cherry picked from commit d7f46fb) * nodejs: disable failing tests on x86_64-darwin (cherry picked from commit 31d2381) * nodejs: skip tests failing in sandbox in all platforms ce685a8 added list of tests failing on sandbox, but for some reason only for Darwin. We should skip those tests on all platforms otherwise OfBorg builds are failing. (cherry picked from commit f5846d2) * nodejs_20: 20.15.1 -> 20.16.0 (cherry picked from commit 35b556d) * nodejs: 22.5.1 -> 22.6.0 (#333210) (cherry picked from commit 4c38d8a) * nodejs_22: 22.6.0 -> 22.7.0 (#336556) (cherry picked from commit c455cc3) * nodejs_20: 20.16.0 -> 20.17.0 (#336388) (cherry picked from commit 45db1ff) * nodejs_22: 22.7.0 -> 22.8.0 (cherry picked from commit 235ae9c) --------- Co-authored-by: K900 <[email protected]> Co-authored-by: Bryan Lai <[email protected]> Co-authored-by: Ivan Trubach <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
https://github.com/nodejs/node/releases/tag/v20.17.0
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.