Unbreak Agda's standard library by bumping to 2.1.1-rc2#336351
Merged
ncfavier merged 1 commit intoNixOS:haskell-updatesfrom Aug 21, 2024
Merged
Unbreak Agda's standard library by bumping to 2.1.1-rc2#336351ncfavier merged 1 commit intoNixOS:haskell-updatesfrom
ncfavier merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
13 tasks
ncfavier
approved these changes
Aug 21, 2024
Member
ncfavier
left a comment
There was a problem hiding this comment.
Reported the agda-prelude failure at UlfNorell/agda-prelude#89
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
When #335932 is merged, our current version (2.1) of Agda's standard library will stop working as #335932 bumps Agda from the old 2.6.4.3 to the new 2.7.0, with which stdlib 2.1 is not compatible.
As a remedy, this pull request bumps Agda's standard library from 2.1 to 2.2.1-rc2.
According to an announcement on the Agda mailing list, the official 2.2.1 is likely to be released in about a week. But as we strive for the master branch to always contain a working Agda environment (including the standard library and a couple of others), I believe that we should bump to 2.2.1-rc2 now instead of shipping a broken version in the window between the marge of haskell-updates and the release of 2.2.1.
This pull request also marks agda-prelude, a different library, as broken, as it is currently not compatible with Agda 2.7.0.
Together with the companion pull request #336027, this pull request ensures that Agda + libraries will work after the merge of #335932, and supersedes the draft pull request #335824. You can test this pull request with:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.