Skip to content

Unbreak Agda's standard library by bumping to 2.1.1-rc2#336351

Merged
ncfavier merged 1 commit intoNixOS:haskell-updatesfrom
iblech:patch-agda-stdlib-2.1.1rc2
Aug 21, 2024
Merged

Unbreak Agda's standard library by bumping to 2.1.1-rc2#336351
ncfavier merged 1 commit intoNixOS:haskell-updatesfrom
iblech:patch-agda-stdlib-2.1.1rc2

Conversation

@iblech
Copy link
Contributor

@iblech iblech commented Aug 21, 2024

Description of changes

When #335932 is merged, our current version (2.1) of Agda's standard library will stop working as #335932 bumps Agda from the old 2.6.4.3 to the new 2.7.0, with which stdlib 2.1 is not compatible.

As a remedy, this pull request bumps Agda's standard library from 2.1 to 2.2.1-rc2.

According to an announcement on the Agda mailing list, the official 2.2.1 is likely to be released in about a week. But as we strive for the master branch to always contain a working Agda environment (including the standard library and a couple of others), I believe that we should bump to 2.2.1-rc2 now instead of shipping a broken version in the window between the marge of haskell-updates and the release of 2.2.1.

This pull request also marks agda-prelude, a different library, as broken, as it is currently not compatible with Agda 2.7.0.

Together with the companion pull request #336027, this pull request ensures that Agda + libraries will work after the merge of #335932, and supersedes the draft pull request #335824. You can test this pull request with:

$ nix-shell -I nixpkgs=https://github.com/iblech/nixpkgs/archive/patch-agda-stdlib-2.1.1rc2.zip -p "agda.withPackages (p: [ p.standard-library p.functional-linear-algebra p.agda-categories p.generics p.cubical ])

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: agda A dependently typed programming language / interactive theorem prover label Aug 21, 2024
@iblech iblech mentioned this pull request Aug 21, 2024
13 tasks
Copy link
Member

@ncfavier ncfavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reported the agda-prelude failure at UlfNorell/agda-prelude#89

@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Aug 21, 2024
@ofborg ofborg bot requested review from alexarice, jwiegley, laMudri and turion August 21, 2024 16:50
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 21, 2024
@ncfavier ncfavier merged commit 540ee94 into NixOS:haskell-updates Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: agda A dependently typed programming language / interactive theorem prover 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants