Skip to content

nix: add nix-team to CODEOWNERS#336270

Merged
edolstra merged 1 commit intoNixOS:masterfrom
Mic92:nix-owner
Aug 22, 2024
Merged

nix: add nix-team to CODEOWNERS#336270
edolstra merged 1 commit intoNixOS:masterfrom
Mic92:nix-owner

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 21, 2024

Description of changes

Depends on NixOS/org#24

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: policy discussion Discuss policies to work in and around Nixpkgs label Aug 21, 2024
@Mic92 Mic92 marked this pull request as draft August 21, 2024 06:21
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 21, 2024
@Mic92 Mic92 marked this pull request as ready for review August 21, 2024 19:41
@Mic92
Copy link
Member Author

Mic92 commented Aug 21, 2024

cc @roberth

Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the suggestion, but 👍

Update .github/CODEOWNERS

Co-authored-by: Robert Hensing <[email protected]>
@edolstra edolstra merged commit a8dc85a into NixOS:master Aug 22, 2024
@Mic92 Mic92 deleted the nix-owner branch August 22, 2024 17:35
@Mic92
Copy link
Member Author

Mic92 commented Aug 23, 2024

Backport #336734

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: policy discussion Discuss policies to work in and around Nixpkgs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants