python312Packages.rx: update disable test reason#336219
Merged
emilazy merged 3 commits intoNixOS:masterfrom Sep 22, 2024
Merged
python312Packages.rx: update disable test reason#336219emilazy merged 3 commits intoNixOS:masterfrom
emilazy merged 3 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
10.rebuild-darwin: 1-10
Member
There was a problem hiding this comment.
Why not fetch from git then?
Member
Author
There was a problem hiding this comment.
There is a notice about it above:
# Use fetchPypi to avoid the updater script to migrate it to `reactivex` which
# is being developed in the same repository
Contributor
There was a problem hiding this comment.
The branch release/v3.2.x via fetchGitHub should be used as it still only rx with tests and not reactivex
Member
Author
There was a problem hiding this comment.
I think this is outside the scope of this pr isn't it?
Member
There was a problem hiding this comment.
That's not a valid reason. We can just disable the update bot.
emilazy
approved these changes
Sep 22, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
It would be good to test this but the tests were already disabled for being flaky before and this migrates to pyproject without making anything worse. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.