Merged
Conversation
Long‐dead upstream (completely vanished, in fact), using a release from 2013, barely surviving on a huge pile of Debian patches and drive‐by fixes. Even the Debian patch set in our package here is out of date. The `meta.homepage` was updated to point to a GitHub repository with commits from as recently as 5½ years ago, but that appears to be a separate fork from another developer, and we never actually shipped it. The last time this package was substantially touched was by @vs49688, who heroically took the time to patch it to update it from FFmpeg 2(!) to FFmpeg 4 as part of a tree‐wide sweep almost three years ago. Now that I’m dealing with FFmpeg 4, it would need patching again, and I really don’t feel like it. I considered simply dropping the FFmpeg dependency by disabling compressed CDDA support, but it’s just not worth it to keep this package alive. The state of PlayStation emulation has improved dramatically from when this fork was current. DuckStation and Mednafen are both better options for the majority of people. The PCSX Reloaded code lives on as PCSX ReARMed, which we package as a libretro core, but not as a standalone emulator. I would encourage anyone who has reason to want a packaged PCSX fork to package the standalone version of PCSX ReARMed from <https://github.com/notaz/pcsx_rearmed>. You can tag me for review if you’d like.
ofborg
bot
added
8.has: clean-up
donovanglover
approved these changes
Aug 21, 2024
donovanglover
added
the
12.approvals: 1
Contributor
|
Ahh, I remember doing this. That was before I knew DuckStation existed. Yeet it. With Fire. |
vs49688
approved these changes
Aug 21, 2024
Member
Author
|
With pleasure! Huge respect for diving in and patching it last time though 💜 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Long‐dead upstream (completely vanished, in fact), using a release from 2013, barely surviving on a huge pile of Debian patches and drive‐by fixes. Even the Debian patch set in our package here is out of date. The
meta.homepagewas updated to point to a GitHub repository with commits from as recently as 5½ years ago, but that appears to be a separate fork from another developer, and we never actually shipped it.The last time this package was substantially touched was by @vs49688, who heroically took the time to patch it to update it from FFmpeg 2(!) to FFmpeg 4 as part of a tree‐wide sweep almost three years ago. Now that I’m dealing with FFmpeg 4, it would need patching again, and I really don’t feel like it.
I considered simply dropping the FFmpeg dependency by disabling compressed CDDA support, but it’s just not worth it to keep this package alive. The state of PlayStation emulation has improved dramatically from when this fork was current. DuckStation and Mednafen are both better options for the majority of people. The PCSX Reloaded code lives on as PCSX ReARMed, which we package as a libretro core, but not as a standalone emulator. I would encourage anyone who has reason to want a packaged PCSX fork to package the standalone version of PCSX ReARMed from https://github.com/notaz/pcsx_rearmed. You can tag me for review if you’d like.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.