Skip to content

python312Packages.clustershell: drop nose dependency#336158

Merged
emilazy merged 1 commit intoNixOS:masterfrom
Sigmanificient:clustershell
Sep 22, 2024
Merged

python312Packages.clustershell: drop nose dependency#336158
emilazy merged 1 commit intoNixOS:masterfrom
Sigmanificient:clustershell

Conversation

@Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Aug 20, 2024

Description of changes

Couldn't get it to work with pytestCheckHook

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 20, 2024
@ofborg ofborg bot requested a review from alexvorobiev August 20, 2024 21:42
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 20, 2024
@SuperSandro2000
Copy link
Member

It wants to import distuitls. Try adding setuptools.

@Sigmanificient
Copy link
Member Author

works with build-system = [ setuptools distutils ];

@emilazy
Copy link
Member

emilazy commented Sep 22, 2024

Result of nixpkgs-review pr 336158 run on aarch64-linux 1

4 packages built:
  • python311Packages.clustershell
  • python311Packages.clustershell.dist
  • python312Packages.clustershell
  • python312Packages.clustershell.dist

@emilazy emilazy merged commit e0d069b into NixOS:master Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants