Skip to content

python312Packages.blessings: drop#336152

Merged
emilazy merged 10 commits intoNixOS:masterfrom
Sigmanificient:blessings
Sep 22, 2024
Merged

python312Packages.blessings: drop#336152
emilazy merged 10 commits intoNixOS:masterfrom
Sigmanificient:blessings

Conversation

@Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Aug 20, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 20, 2024
@Sigmanificient Sigmanificient force-pushed the blessings branch 2 times, most recently from 16736a4 to ac54491 Compare August 20, 2024 20:21
@Sigmanificient Sigmanificient mentioned this pull request Aug 20, 2024
Closed
@emilazy
Copy link
Member

emilazy commented Aug 20, 2024

This package seems to be somewhat famously unmaintained, and there is a maintained fork in the form of Blessed that already uses pytest. We already have a python3Packages.blessed package; perhaps we can simply remove this. In‐tree users:

  • cbeams: Doesn’t look very maintained, but terminal.py seems simple enough that I expect the port is simple.
  • python3Packages.invocations: blessings is dead pyinvoke/invocations#38, looks like probably a one‐line import change to port to Blessed.
  • python3Packages.ronin: Build system with no commits for 7 years and no in‐tree users, not exposed in the top‐level package set, ditto on the port but we can probably just drop this.
  • python3Packages.reportengine: Marked as broken, unmaintained‐ish upstream, and could potentially just be dropped, but ditto on the port.

@ofborg ofborg bot requested a review from domenkozar August 20, 2024 21:06
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 20, 2024
@Sigmanificient
Copy link
Member Author

Sigmanificient commented Aug 20, 2024

@emilazy tried to makes reportengine passing, couldn't successfully patch it, so I dropped it. It also takes 2 other packages with it

@Sigmanificient
Copy link
Member Author

Sigmanificient commented Aug 20, 2024

Result of nixpkgs-review pr 336152 run on x86_64-linux 1

10 packages built:
  • cbeams
  • cbeams.dist
  • python311Packages.invocations
  • python311Packages.invocations.dist
  • python311Packages.pytest-relaxed
  • python311Packages.pytest-relaxed.dist
  • python312Packages.invocations
  • python312Packages.invocations.dist
  • python312Packages.pytest-relaxed
  • python312Packages.pytest-relaxed.dist

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package labels Aug 20, 2024
@ofborg ofborg bot requested review from oxzi and samuela August 20, 2024 23:53
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 20, 2024
SuperSandro2000
SuperSandro2000 reviewed Aug 22, 2024
View reviewed changes
pkgs/top-level/python-aliases.nix Outdated
Copy link
Member

@SuperSandro2000 SuperSandro2000 Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please name it explicitly

Copy link
Member

@emilazy emilazy Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?

Copy link
Member Author

@Sigmanificient Sigmanificient Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure to see what is problematic here

pkgs/top-level/aliases.nix Outdated
Copy link
Member

@SuperSandro2000 SuperSandro2000 Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

pkgs/top-level/python-aliases.nix Outdated
Copy link
Member

@SuperSandro2000 SuperSandro2000 Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

emilazy
emilazy approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the PR title? Otherwise this seems good to merge to me.

@emilazy
Copy link
Member

emilazy commented Sep 22, 2024

Result of nixpkgs-review pr 336152 run on aarch64-linux 1

10 packages built:
  • cbeams
  • cbeams.dist
  • python311Packages.invocations
  • python311Packages.invocations.dist
  • python311Packages.pytest-relaxed
  • python311Packages.pytest-relaxed.dist
  • python312Packages.invocations
  • python312Packages.invocations.dist
  • python312Packages.pytest-relaxed
  • python312Packages.pytest-relaxed.dist

@emilazy emilazy changed the title python312Packages.blessings: drop nose dependency python312Packages.blessings: drop Sep 22, 2024
emilazy
emilazy approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remembered I can do that myself :)

@emilazy emilazy merged commit 3b5f32c into NixOS:master Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilazy emilazy emilazy approved these changes

@domenkozar domenkozar Awaiting requested review from domenkozar

@natsukium natsukium Awaiting requested review from natsukium

@samuela samuela Awaiting requested review from samuela

@oxzi oxzi Awaiting requested review from oxzi

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sigmanificient @emilazy @SuperSandro2000