Merged
Conversation
This builds fine with OpenCV 4.
This builds fine with OpenCV 4 using `enableUnfree`.
These versions have been obsolete for 5 to 10 years, and have been broken since 34cd490 unless the user specifies manual overrides. Given that nobody seems to have reported an issue with them, I conclude that demand for them is minimal and that there’s no need for them to block the removal of OpenCV 2.
Essentially unmaintained upstream for almost a decade, kept alive with treewides and drive‐by fixes, and depends on the deprecated and removed OpenCV C API. Sorry, it looks like a fun toy! Hopefully someone can port it to a newer OpenCV.
github-actions
bot
added
6.topic: nixos
Member
|
@ofborg eval |
ofborg
bot
added
the
8.has: clean-up
ofborg
bot
added
10.rebuild-darwin: 0
SuperSandro2000
approved these changes
Aug 22, 2024
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The final non‐trivial stretch of the FFmpeg 4 mostly‐removal. It would be sufficient to simply disable FFmpeg support for these versions, but as they are obsolete and were almost unused in‐tree, let’s extend the old versions clean‐up task to OpenCV as well.
opencv3was unreferenced except as part of the already‐brokenhaskellPackages.opencv{,-extra}packages. Those will hopefully be fixed by LumiGuide/haskell-opencv#157 in the future. I confirmed with the Haskell maintainers that the dangling reference inside the automatically‐generatedhaskellPackages.opencvdefinition is desired and that this PR does not break eval; see #336110 for the corresponding clean‐up PR tohaskell-updates.opencv2was referenced by two packages that build fine with the latest version, long‐obsolete (and already broken‐by‐default) versions of Mathematica, and a cute but sadly bitrotten terminal video chat program. See the commit messages for further details and rationales.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.