python312Packages.apricot-select: drop nose dependency#336133
Merged
fabaff merged 1 commit intoNixOS:masterfrom Aug 31, 2024
Merged
python312Packages.apricot-select: drop nose dependency#336133fabaff merged 1 commit intoNixOS:masterfrom
fabaff merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
Sigmanificient
force-pushed
the
apricot-select
branch
from
1e5fd93 to
03a4cee
Compare
Member
|
@ofborg eval |
ofborg
bot
added
10.rebuild-darwin: 1-10
Member
|
Result of 4 packages built:
|
NickCao
previously requested changes
Aug 21, 2024
Member
NickCao
left a comment
NickCao
left a comment
There was a problem hiding this comment.
nose is still in nativeCheckInputs
Sigmanificient
force-pushed
the
apricot-select
branch
from
03a4cee to
53e0a95
Compare
Member
There was a problem hiding this comment.
Please go to the Nixpkgs root directory, run
nix-shell, then:
nixfmt 'pkgs/development/python-modules/apricot-select/default.nix'
Member
SuperSandro2000
left a comment
SuperSandro2000
left a comment
There was a problem hiding this comment.
on ofborg the tests hang and time out
Sigmanificient
force-pushed
the
apricot-select
branch
from
53e0a95 to
3975369
Compare
Member
Author
yes that why there is a |
Member
|
Result of 4 packages built:
|
fabaff
approved these changes
Aug 31, 2024
Member
fabaff
left a comment
fabaff
left a comment
There was a problem hiding this comment.
Change looks good to me.
Let's keep the test sections and hope that upstream fixed the issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.