treewide: remove xxxFlagsArray from nix derivations#335925
Merged
philiptaron merged 2 commits intoNixOS:stagingfrom Aug 20, 2024
Merged
treewide: remove xxxFlagsArray from nix derivations#335925philiptaron merged 2 commits intoNixOS:stagingfrom
philiptaron merged 2 commits intoNixOS:stagingfrom
Conversation
The xxxFlagsArray variants were never meant to be used in nix code, at least they can't be used properly without __structuredAttrs turned on. If no spaces are passed in the argument the xxxFlagsArray can be replaced as-is with the non-Array variant. When whitespace needs to be passed, the derivation is additionally changed to enable __structuredAttrs.
buildPecl overwrites the checkPhase like this: checkPhase = "NO_INTERACTON=yes make test"; Thus none of the checkXXX options set in nix are actually used.
wolfgangwalther
requested review from
Ma27,
aanderse,
drupol,
globin and
talyz
as code owners
github-actions
bot
added
the
6.topic: php
13 tasks
ofborg
bot
added
10.rebuild-darwin: 501+
philiptaron
approved these changes
Aug 20, 2024
Contributor
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
Built every package on x86_64-linux. I intend to merge this tomorrow; keeping it open to hear any other commentary.
GaetanLepage
added a commit
to nix-community/neovim-nightly-overlay
that referenced
this pull request
Sep 25, 2024
GaetanLepage
added a commit
to nix-community/neovim-nightly-overlay
that referenced
this pull request
Sep 25, 2024
willruggiano
pushed a commit
to nix-community/neovim-nightly-overlay
that referenced
this pull request
Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
For rationale, see #335110.
CC @emilazy @philiptaron @SomeoneSerge
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.