emacs: let nix build for manualPackages fail if native-comp fails#335440
Merged
jian-lin merged 4 commits intoNixOS:masterfrom Aug 22, 2024
Merged
Conversation
It is deprecated in favor of emacsPackages.ement and there is error in its native compilation.
This helps find packaging issues or issues in the package itself.
jian-lin
force-pushed
the
pr/emacs-manualPackages-resepct-compilation-error
branch
from
b7701fb to
2421239
Compare
ofborg
bot
added
8.has: clean-up
Contributor
Author
|
Result of 44 packages built:
|
jian-lin
commented
Aug 19, 2024
Contributor
Author
There was a problem hiding this comment.
This is a pretty safe PR because it does not break packages.
Two things worth discussion are
- should the deprecated
matrix-clientbe dropped? - do we want to make
nix buildfail if there are native compilation errors? The PR only deals with manualPackages. Doing so for all packages is tracked in Flip the default value ofignoreCompilationErrortofalsefor Emacs package #335442.
WDYT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The first and easy part of #335442.
This helps find packaging issues or issues in the package itself.
During the process, some issues are found:
emacsPackages.voicemacsmisses a dependency which is added in this PR.emacsPackages.prisma-modemisses a dependency which is added in this PR.emacsPackages.matrix-client. I delete it in this PR because it is deprecated in favor ofemacsPackages.ement.emacsPackages.tsc. I create emacsPackages.tsc: refactor #335438 to fix that.emacsPackages.color-theme-solarized, which is tracked by There are errors in native compliation of emacsPackages.color-theme-solarized #335408.emacsPackages.consult-gh, which is tracked by There are errors in native compliation of emacsPackages.consult-gh #335411.emacsPackages.session-management-for-emacs, which is tracked by There are errors in native compliation of emacsPackages.session-management-for-emacs #335421.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.