Merged
Conversation
13 tasks
ofborg
bot
added
8.has: package (new)
adisbladis
reviewed
Aug 18, 2024
Member
There was a problem hiding this comment.
We shouldn't check lock files into nixpkgs: #327064.
Contributor
Author
There was a problem hiding this comment.
When there are git dependencies in Cargo.lock, we have to do this instead of using cargoHash.
nixpkgs/pkgs/build-support/rust/fetch-cargo-tarball/default.nix
Lines 79 to 88 in abcef4d
IMHO, #327064 means if there is no git dependency we should always prefer cargoHash.
AndersonTorres
approved these changes
Aug 18, 2024
jian-lin
commented
Aug 18, 2024
pkgs/applications/editors/emacs/elisp-packages/manual-packages/tsc/package.nix
Outdated
Show resolved
Hide resolved
jian-lin
force-pushed
the
pr/refactor-emacs-tsc
branch
from
bc0a894 to
613764e
Compare
- use melpaBuild as the main derivation - use cargoLock due to git deps in Cargo.lock - use nix-update-script as the update script - fix errors in native compilations - rename dynamic module with the help of stdenv.hostPlatform.extensions.sharedLibrary instead of bash magic - remove unneeded rustPlatform.bindgenHook
jian-lin
force-pushed
the
pr/refactor-emacs-tsc
branch
from
613764e to
f7fbcb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #335442
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.