lib.systems.doubles: add aarch64-windows double#335067
Merged
Ericson2314 merged 8 commits intoNixOS:masterfrom Nov 7, 2024
Merged
lib.systems.doubles: add aarch64-windows double#335067Ericson2314 merged 8 commits intoNixOS:masterfrom
Ericson2314 merged 8 commits intoNixOS:masterfrom
Conversation
getchoo
requested review from
Ericson2314,
RossComputerGuy and
alyssais
as code owners
github-actions
bot
added
6.topic: lib
Member
Author
|
|
getchoo
force-pushed
the
lib/systems/aarch64-windows
branch
from
3f6ac31 to
9fc8505
Compare
alyssais
previously requested changes
Aug 16, 2024
Member
alyssais
left a comment
alyssais
left a comment
There was a problem hiding this comment.
Very nice. Thanks for keeping the commits so small and easy to read!
ofborg
bot
added
10.rebuild-darwin: 1-10
getchoo
force-pushed
the
lib/systems/aarch64-windows
branch
2 times, most recently
from
7cceda9 to
4360f77
Compare
Member
Author
|
Resolved a merge conflict from #334470 |
wegank
added
the
2.status: merge conflict
Changelog: https://www.mingw-w64.org/changelog/#v1200-2024-05-29 Only notable change for our purposes is UCRT now being the default, so either it or MSVCRT must be explicitly passed
getchoo
force-pushed
the
lib/systems/aarch64-windows
branch
from
4360f77 to
fb917de
Compare
getchoo
removed
the
2.status: merge conflict
nix-owners
bot
requested review from
philiptaron,
reckenrode,
rrbutani and
sternenseemann
Member
|
Oh very cool! |
Contributor
|
@getchoo awesome project |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This introduces initial support for cross compiling to Windows on Arm in nixpkgs
It adds a new example system (and
pkgsCrosstarget) inucrtAarch64. It is modeled after MSYS2's CLANGARM64 environment, which is based on LLVM. Windows-specific fixes for a few LLVM packages have been applied due to thisCurrently
stdenv.ccbuilds but doesn't seem to work all too well --helloerrors out early, reportingC compiler cannot create executables. Help would be appreciated here!Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.