Skip to content

python3Packages.pid: remove nose dependency#334761

Merged
pbsds merged 1 commit intoNixOS:masterfrom
mindstorms6:python3packages-pid-remove-nose
Aug 18, 2024
Merged

python3Packages.pid: remove nose dependency#334761
pbsds merged 1 commit intoNixOS:masterfrom
mindstorms6:python3packages-pid-remove-nose

Conversation

@mindstorms6
Copy link
Member

Description of changes

pid package no longer needs nose as of this commit - remove nose dependency.

(Recreates/fixes #327372)

Addresses #326513.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 15, 2024
@mindstorms6 mindstorms6 requested a review from emilazy August 15, 2024 03:21
@mindstorms6 mindstorms6 force-pushed the python3packages-pid-remove-nose branch 3 times, most recently from 5c259ce to a8c3769 Compare August 15, 2024 03:55
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 15, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move build-system between patches and nativeCheckInputs

@mindstorms6 mindstorms6 force-pushed the python3packages-pid-remove-nose branch from a8c3769 to b7009eb Compare August 18, 2024 14:11
@pbsbot
Copy link

pbsbot commented Aug 18, 2024

Result of nixpkgs-review pr 334761 run on x86_64-linux 1

2 packages failed to build:
  • irrd
  • irrd.dist
6 packages built:
  • appdaemon
  • appdaemon.dist
  • python311Packages.pid
  • python311Packages.pid.dist
  • python312Packages.pid
  • python312Packages.pid.dist

@pbsds
Copy link
Member

pbsds commented Aug 18, 2024

@pbsds pbsds merged commit bc9910d into NixOS:master Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants