Skip to content

python312Packages.wsme: drop nose dependency#334472

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Sigmanificient:wsme-nose
Aug 22, 2024
Merged

python312Packages.wsme: drop nose dependency#334472
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Sigmanificient:wsme-nose

Conversation

@Sigmanificient
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 13, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 13, 2024
@emilazy
Copy link
Member

emilazy commented Aug 13, 2024

This has no maintainer, isn’t used by anything in tree, has been disabled on Python ≥ 3.9 for years, and has been kept alive by mass bumps and Zero Hydra Failures for years…

Upstream doesn’t seem to be totally dead but I’m wondering if it’s worth continuing to devote more collective effort to this package that I get the impression nobody is using. It doesn’t have many reverse dependencies on PyPI.

Are you interested in adopting this package? If so, we ought to do a bit more clean‐up (e.g. it doesn’t depend on six any more at a glance, and there might be other outdated dependencies). Otherwise, maybe we should just drop this and if anyone else wants to use it they can easily bring it back and take up maintenance.

@Sigmanificient
Copy link
Member Author

I can maintain it i think

@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Aug 14, 2024
@SuperSandro2000 SuperSandro2000 merged commit cb8e001 into NixOS:master Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants