treewide/pkgs: remove 'with lib;'#334470
Merged
fricklerhandwerk merged 55 commits intoNixOS:masterfrom Aug 16, 2024
Merged
Conversation
Stunkymonkey
force-pushed
the
treewide-pkgs-remove-with-lib
branch
from
9e68181 to
ce965f9
Compare
Contributor
|
Thanks. I'll take a look soon. Cc: @fricklerhandwerk |
philiptaron
previously requested changes
Aug 14, 2024
Contributor
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
Let's fix up the ofBorg eval failures first, then I'll do the work of reading through it.
Stunkymonkey
force-pushed
the
treewide-pkgs-remove-with-lib
branch
from
ce965f9 to
91b4f3a
Compare
Contributor
|
Nice! Ping me again if it evaluates and I'll merge. |
Contributor
|
We've still got some eval failures. https://gist.github.com/GrahamcOfBorg/cc1908adc2ba48974920d44e85b6f625 |
Stunkymonkey
force-pushed
the
treewide-pkgs-remove-with-lib
branch
2 times, most recently
from
30c4126 to
da39669
Compare
Stunkymonkey
force-pushed
the
treewide-pkgs-remove-with-lib
branch
from
da39669 to
8eaeb5e
Compare
Contributor
|
@Stunkymonkey: I use some variant of this as a cheap-and-cheerful test that definitely doesn't do the same thing as ofBorg but does make sure that everything parses at the top level. See |
ofborg
bot
added
10.rebuild-darwin: 0
Contributor
Author
|
ping @fricklerhandwerk |
fricklerhandwerk
approved these changes
Aug 16, 2024
Contributor
🔆 🙌🏻Way to go @Stunkymonkey! |
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
part of #208242
my goal was to remove all single-line
with lib;frompkgs/Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.