python312Packages.scales: run tests using pytestCheckHook#334466
Closed
Sigmanificient wants to merge 1 commit intoNixOS:masterfrom
Closed
python312Packages.scales: run tests using pytestCheckHook#334466Sigmanificient wants to merge 1 commit intoNixOS:masterfrom
Sigmanificient wants to merge 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
10.rebuild-darwin: 1-10
emilazy
reviewed
Sep 22, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
This is only used as an optional dependency in one other package, and hasn’t seen a release in almost a decade. Perhaps we should just drop it and remove the optional dependency from cassandra-driver?
If not, this should be migrated to pyproject at least.
13 tasks
Member
|
I've made #348559 which incorporates the changes from this PR as well as a few extra changes that were noted above. |
Member
|
Closing as #348559 was merged. Thank you for working on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.