tarsnapper: drop nose dependency#334462
Merged
Atemu merged 1 commit intoNixOS:masterfrom Aug 18, 2024
Merged
Conversation
ofborg
bot
added
10.rebuild-darwin: 1-10
gmacon
approved these changes
Aug 14, 2024
Contributor
gmacon
left a comment
gmacon
left a comment
There was a problem hiding this comment.
Builds OK and tests pass on x86_64-linux. LGTM. Thanks!
wegank
added
12.approvals: 1
Sigmanificient
force-pushed
the
tarsnapper
branch
from
cf9e263 to
aae067c
Compare
Member
Author
|
Sorry took me a while, I have too many github notifications 😅 |
Contributor
|
No worries. We have to wait for a committer anyway. |
gmacon
approved these changes
Aug 17, 2024
Atemu
requested changes
Aug 17, 2024
Sigmanificient
force-pushed
the
tarsnapper
branch
from
aae067c to
9e2a18a
Compare
Sigmanificient
force-pushed
the
tarsnapper
branch
from
9e2a18a to
303f998
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.