Skip to content

[staging] util-linux: 2.39.4 -> 2.40.2#333467

Closed
dasJ wants to merge 1 commit intoNixOS:stagingfrom
helsinki-systems:upd/util-linux
Closed

[staging] util-linux: 2.39.4 -> 2.40.2#333467
dasJ wants to merge 1 commit intoNixOS:stagingfrom
helsinki-systems:upd/util-linux

Conversation

@dasJ
Copy link
Member

@dasJ dasJ commented Aug 9, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Aug 9, 2024
@emilazy
Copy link
Member

emilazy commented Oct 7, 2024

This will need fixes for the Darwin issues reported last time; applying util-linux/util-linux#3013 and potentially adding memorymappingHook for the fmemopen issue should do it.

(Happy to help with this & testing builds if needs be.)

@leona-ya
Copy link
Member

leona-ya commented Oct 7, 2024

For me the util-linux build is broken with

/nix/store/0kg70swgpg45ipcz3pr2siidq9fn6d77-coreutils-9.5/bin/mkdir: cannot create directory '/nix/store/2i21jv4iaacd2vylj5j3j1jv04a6fyhy-systemd-256.4/lib/tmpfiles.d': Permission denied /nix/store/0kg70swgpg45ipcz3pr2siidq9fn6d77-coreutils-9.5/bin/mkdir -p '/nix/store/56ikq0xkr7zhx4hmdx3053gg1kr4j7ff-util-linux-2.40.2-dev/include/uuid'

@alyssais
Copy link
Member

alyssais commented Oct 8, 2024

Given what happened last time we tried this, I think it might be better not to do it in the last staging cycle before freeze.

@emilazy

This comment was marked as resolved.

@YellowOnion
Copy link
Contributor

@alyssais the newer bcachefs-tools and old util-linux can't mount my filesystem due to a bug in util-linux that was fixed in 2.40, I was kinda hoping that I could unpin bcachefs-tools since it's already about 9 months out of date, You did mention backporting the patches in June, but that never ended up happening.

I'm fine with waiting a few extra months, but if there's any other options that would be sweet too.

@alyssais
Copy link
Member

alyssais commented Oct 9, 2024

You did mention backporting the patches in June, but that never ended up happening.

I'm fine with waiting a few extra months, but if there's any other options that would be sweet too.

Backporting the patches is still an option. Somebody just needs to open a PR.

g2p added a commit to g2p/bcachefs-tools that referenced this pull request Oct 28, 2024
2.40.1 is still a soft requirement as format will refuse
to run without a flag.

nixpkgs requiring macOS compatibility of util-linux is a questionable
choice.

See:
- NixOS/nixpkgs#333467
- util-linux/util-linux#3013

Rationale for picking blkid 2.39.3:
https://mirrors.edge.kernel.org/pub/linux/utils/util-linux/v2.39/v2.39.3-ReleaseNotes
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 9, 2024
@FlyingWombat
Copy link
Contributor

This needs "--with-tmpfilesdir=${placeholder "out"}/lib/tmpfiles.d" in configureFlags to build.

@FlyingWombat
Copy link
Contributor

FlyingWombat commented Nov 23, 2024

Would it be reasonable to apply the Darwin build fix util-linux/util-linux#3013 as a patch until it gets merged upstream?

I've run a full system rebuild on my machine (NixOS) with this change, with no issues.

Is there anything else blocking moving forward with this update?

@alyssais
Copy link
Member

Would it be reasonable to apply the Darwin build fix util-linux/util-linux#3013 as a patch until it gets merged upstream?

Yes. It might also be good if somebody could resubmit it upstream, since it doesn't look like anybody is currently working on upstream's feedback (about the commit message).

@FlyingWombat
Copy link
Contributor

@dasJ Please rebase this PR and make these changes:

If you are too busy, let me know and I'll make a new PR.

@ghost ghost mentioned this pull request Dec 28, 2024
1 task
@xaverdh
Copy link
Contributor

xaverdh commented Jan 10, 2025

by the way 2.40.3 was tagged by now

@leona-ya
Copy link
Member

Just tested the boot of one of my devices (lvm with xfs inside luks) with util-linux 2.40.3. Still doesn't boot. Will later search again for an issue or report it (even though I don't really know where to start)

@YellowOnion
Copy link
Contributor

Can we get some movement on this? @alyssais @vcunat IIRC it needs to go through staging.

I think my bcachefs-tools is now officially 1 year out of date lol.

@leona-ya boot with kernel parameter boot.debug1devices and manually mount it, run dmesg etc. I have xfs + luks on my laptop, so maybe I can test as well, just don't want to spend ages compiling.

@vcunat
Copy link
Member

vcunat commented Jan 11, 2025

Yes, it does need to go through staging, and it's correctly targeted there. But is it worth risking if we know about some use case(s) that get broken by this update?

@xaverdh xaverdh mentioned this pull request Jan 23, 2025
13 tasks
@xaverdh
Copy link
Contributor

xaverdh commented Jan 24, 2025

more recent pr is here: #376007

@alyssais alyssais closed this Feb 9, 2025
g2p added a commit to g2p/bcachefs-tools that referenced this pull request Mar 17, 2025
2.40.1 is still a soft requirement as format will refuse
to run without a flag.

nixpkgs requiring macOS compatibility of util-linux is a questionable
choice.

See:
- NixOS/nixpkgs#333467
- util-linux/util-linux#3013

Rationale for picking blkid 2.39.3:
https://mirrors.edge.kernel.org/pub/linux/utils/util-linux/v2.39/v2.39.3-ReleaseNotes
g2p added a commit to g2p/bcachefs-tools that referenced this pull request Mar 17, 2025
2.40.1 is still a soft requirement as format will refuse
to run without a flag.

nixpkgs requiring macOS compatibility of util-linux is a questionable
choice.

See:
- NixOS/nixpkgs#333467
- util-linux/util-linux#3013

Rationale for picking blkid 2.39.3:
https://mirrors.edge.kernel.org/pub/linux/utils/util-linux/v2.39/v2.39.3-ReleaseNotes

Signed-off-by: Gabriel de Perthuis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

9 participants