[staging] util-linux: 2.39.4 -> 2.40.2#333467
Conversation
|
This will need fixes for the Darwin issues reported last time; applying util-linux/util-linux#3013 and potentially adding (Happy to help with this & testing builds if needs be.) |
|
For me the |
|
Given what happened last time we tried this, I think it might be better not to do it in the last staging cycle before freeze. |
This comment was marked as resolved.
This comment was marked as resolved.
|
@alyssais the newer bcachefs-tools and old util-linux can't mount my filesystem due to a bug in util-linux that was fixed in 2.40, I was kinda hoping that I could unpin bcachefs-tools since it's already about 9 months out of date, You did mention backporting the patches in June, but that never ended up happening. I'm fine with waiting a few extra months, but if there's any other options that would be sweet too. |
Backporting the patches is still an option. Somebody just needs to open a PR. |
2.40.1 is still a soft requirement as format will refuse to run without a flag. nixpkgs requiring macOS compatibility of util-linux is a questionable choice. See: - NixOS/nixpkgs#333467 - util-linux/util-linux#3013 Rationale for picking blkid 2.39.3: https://mirrors.edge.kernel.org/pub/linux/utils/util-linux/v2.39/v2.39.3-ReleaseNotes
|
This needs |
|
Would it be reasonable to apply the Darwin build fix util-linux/util-linux#3013 as a patch until it gets merged upstream? I've run a full system rebuild on my machine (NixOS) with this change, with no issues. Is there anything else blocking moving forward with this update? |
Yes. It might also be good if somebody could resubmit it upstream, since it doesn't look like anybody is currently working on upstream's feedback (about the commit message). |
|
@dasJ Please rebase this PR and make these changes:
If you are too busy, let me know and I'll make a new PR. |
|
by the way 2.40.3 was tagged by now |
|
Just tested the boot of one of my devices (lvm with xfs inside luks) with util-linux 2.40.3. Still doesn't boot. Will later search again for an issue or report it (even though I don't really know where to start) |
|
Can we get some movement on this? @alyssais @vcunat IIRC it needs to go through staging. I think my bcachefs-tools is now officially 1 year out of date lol. @leona-ya boot with kernel parameter |
|
Yes, it does need to go through |
|
more recent pr is here: #376007 |
2.40.1 is still a soft requirement as format will refuse to run without a flag. nixpkgs requiring macOS compatibility of util-linux is a questionable choice. See: - NixOS/nixpkgs#333467 - util-linux/util-linux#3013 Rationale for picking blkid 2.39.3: https://mirrors.edge.kernel.org/pub/linux/utils/util-linux/v2.39/v2.39.3-ReleaseNotes
2.40.1 is still a soft requirement as format will refuse to run without a flag. nixpkgs requiring macOS compatibility of util-linux is a questionable choice. See: - NixOS/nixpkgs#333467 - util-linux/util-linux#3013 Rationale for picking blkid 2.39.3: https://mirrors.edge.kernel.org/pub/linux/utils/util-linux/v2.39/v2.39.3-ReleaseNotes Signed-off-by: Gabriel de Perthuis <[email protected]>
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.