python312Packages.pygatt: 4.0.5 -> 5.0.0, python312Packages.meshtastic: 2.3.11 -> 2.3.14 #332660
Merged
fabaff merged 4 commits intoNixOS:masterfrom Aug 7, 2024
Merged
python312Packages.pygatt: 4.0.5 -> 5.0.0, python312Packages.meshtastic: 2.3.11 -> 2.3.14 #332660fabaff merged 4 commits intoNixOS:masterfrom
fabaff merged 4 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
11.by: package-maintainer
fabaff
force-pushed
the
pygatt-bump
branch
3 times, most recently
from
3c45d29 to
c9ebb9e
Compare
ofborg
bot
added
8.has: package (new)
This comment was marked as outdated.
This comment was marked as outdated.
fabaff
changed the title
Module for Riden RD power supplies https://github.com/geeksville/riden
Member
Author
|
Result of 16 packages built:
|
ofborg
bot
added
10.rebuild-darwin: 1-10
Member
|
I wanted to bring up a concern regarding PR #330688, where you requested a change about a week ago. Other reviewers provided additional arguments the same day, which left some uncertainty about how to proceed. However, instead of following up on the ongoing discussion, you self-merged your own PR without revisiting the earlier one, which was less than a week old. I understand you're doing tremendous work on nixpkgs, and it’s possible this slipped through the cracks. Still, this could be discouraging for contributors who are waiting for their work to be reviewed. Taking a moment to check for ongoing discussions is important to ensure everyone’s efforts are respected and to maintain a positive collaborative environment. Thank you for your consideration. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diff: peplin/pygatt@refs/tags/v4.0.5...v5.0.0
Changelog: https://github.com/peplin/pygatt/blob/v5.0.0/CHANGELOG.rst
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.