Skip to content

python312Packages.libgpuarray: drop#331841

Merged
emilazy merged 1 commit intoNixOS:masterfrom
pyrox0:drop/libgpuarray
Aug 9, 2024
Merged

python312Packages.libgpuarray: drop#331841
emilazy merged 1 commit intoNixOS:masterfrom
pyrox0:drop/libgpuarray

Conversation

@pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Aug 2, 2024

Description of changes

The package has not been maintained aside from small bugfixes and formatting fixes in nixpkgs, and its last commit in its upstream repo was 5 years ago. It is not depended on by anything else in nixpkgs, and the nixpkgs maintainer has not been active on github for several years. This is also part of #326513, as it depends on nose.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pyrox0 pyrox0 requested a review from natsukium as a code owner August 2, 2024 19:35
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 2, 2024
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 2, 2024
Copy link
Contributor

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add an entry to python-aliases

The package has not been maintained aside from small bugfixes and
formatting fixes, and is not depended on by anything else, therefore it
should be good to drop now.
@pyrox0 pyrox0 force-pushed the drop/libgpuarray branch from 1ff57ff to 96430ae Compare August 4, 2024 02:20
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 4, 2024
@emilazy emilazy merged commit d8fb632 into NixOS:master Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants