Skip to content

[staging] iproute2: fix static build again#331699

Merged
Mic92 merged 1 commit intoNixOS:stagingfrom
Mic92:iproute2
Aug 16, 2024
Merged

[staging] iproute2: fix static build again#331699
Mic92 merged 1 commit intoNixOS:stagingfrom
Mic92:iproute2

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 2, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Mic92 Mic92 changed the base branch from master to staging August 2, 2024 07:16
@Mic92 Mic92 changed the title iproute2: fix static build again [staging] iproute2: fix static build again Aug 2, 2024
@ofborg ofborg bot requested review from edolstra, fpletz, globin and primeos August 2, 2024 07:29
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Aug 2, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 3, 2024
@Mic92 Mic92 merged commit 735fb89 into NixOS:staging Aug 16, 2024
@Mic92 Mic92 deleted the iproute2 branch August 16, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants