Skip to content

moc: 2.5.2 -> 2.6-alpha3-unstable-2019-09-14#331634

Merged
Mindavi merged 1 commit intoNixOS:masterfrom
emilazy:push-kuupnqnomklq
Aug 10, 2024
Merged

moc: 2.5.2 -> 2.6-alpha3-unstable-2019-09-14#331634
Mindavi merged 1 commit intoNixOS:masterfrom
emilazy:push-kuupnqnomklq

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Aug 1, 2024

Description of changes

Includes upstream fixes for FFmpeg 4(!), and downstream ones from Cygwin for FFmpeg 6 and 7.

If anyone really like this player, there are a bunch more patches here:

But you should maybe, like, fork it and apply all of these rather than having downstreams carry even more of them.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy emilazy force-pushed the push-kuupnqnomklq branch from a941b38 to 51ec063 Compare August 1, 2024 23:42
@ofborg ofborg bot requested review from eugenezastrogin, jagajaga and pSub August 2, 2024 01:40
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 2, 2024
Includes upstream fixes for FFmpeg 4(!), and downstream ones from
Cygwin for FFmpeg 6 and 7.

If anyone really like this player, there are a bunch more patches here:

* <https://cygwin.com/cgit/cygwin-packages/moc/tree/>
* <https://salsa.debian.org/riesebie/moc/-/tree/master/debian/patches?ref_type=heads>

But you should maybe, like, fork it and apply all of these rather
than having downstreams carry even more of them.
@emilazy emilazy force-pushed the push-kuupnqnomklq branch from 51ec063 to 335d4f5 Compare August 9, 2024 22:00
@Mindavi Mindavi merged commit bfbf2d4 into NixOS:master Aug 10, 2024
@emilazy emilazy mentioned this pull request Aug 21, 2024
13 tasks
@emilazy emilazy deleted the push-kuupnqnomklq branch August 26, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants