harvid: 0.9.0 -> 0.9.1; tidy up#331558
Merged
tomberek merged 10 commits intoNixOS:masterfrom Aug 2, 2024
Merged
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
mitchmindtree
approved these changes
Aug 1, 2024
Member
mitchmindtree
left a comment
mitchmindtree
left a comment
There was a problem hiding this comment.
Thanks @emilazy 🙏
I checked linux ✔️ then and also checked apple darwin with:
NIXPKGS_ALLOW_UNSUPPORTED_SYSTEM=1 nix shell --impure github:emilazy/nixpkgs/push-xlsnptznlrsl#harvidand it seems to work nicely too!
> harvid --help ~
harvid - http ardour video server
Usage: harvid [OPTION] [document-root]
# ...
> nix-info -m ~
- system: `"aarch64-darwin"`
- host os: `Darwin 22.5.0, macOS 13.4.1`
- multi-user?: `yes`
- sandbox: `yes`
- version: `nix-env (Nix) 2.21.0`
- channels(root): `"nixpkgs"`
- nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`Will leave it up to you on whether or not to add the system though 👍
emilazy
force-pushed
the
push-xlsnptznlrsl
branch
from
d751486 to
0793d3e
Compare
Member
Author
|
Oh, oops, I dropped the |
ofborg
bot
added
10.rebuild-darwin: 1-10
mitchmindtree
approved these changes
Aug 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Includes fixes for FFmpeg ≥ 5 and parallel building. I also made it work on macOS.
Result of
nixpkgs-reviewrun on aarch64-linux 11 package failed to build:
2 packages built:
The
ardour_7failure seems unrelated, as it is already broken on Hydra.Diff: x42/harvid@v0.9.0...v0.9.1
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.