Skip to content

darwin.apple_sdk_12_3: propagate CloudKit from CoreData#331378

Merged
gador merged 1 commit intoNixOS:masterfrom
reckenrode:coredata-12.3-fixes
Aug 1, 2024
Merged

darwin.apple_sdk_12_3: propagate CloudKit from CoreData#331378
gador merged 1 commit intoNixOS:masterfrom
reckenrode:coredata-12.3-fixes

Conversation

@reckenrode
Copy link
Contributor

@reckenrode reckenrode commented Jul 31, 2024

Description of changes

CoreData depends on CloudKit in the 12.3 SDK.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@reckenrode
darwin.apple_sdk_12_3: propagate CloudKit from CoreData
50ce305 
CoreData depends on CloudKit in the 12.3 SDK.
@reckenrode reckenrode mentioned this pull request Jul 31, 2024
Merged
13 tasks
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 31, 2024
@gador
Copy link
Member

gador commented Aug 1, 2024

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 331378 run on aarch64-darwin 1

138 packages marked as broken and skipped:
  • airshipper
  • ajour
  • anilibria-winmaclinux
  • anki
  • anki.dist
  • anki.doc
  • anki.man
  • arcan
  • arcan.dev
  • arcan.lib
  • arcan.man
  • ares
  • colloid-kde
  • colloid-kde.sddm
  • dwl
  • dwl.man
  • eyewitness
  • flet-client-flutter
  • flet-client-flutter.debug
  • flet-client-flutter.pubcache
  • flycast
  • fooyin
  • graphite-kde-theme
  • gruvbox-gtk-theme
  • jellyfin-mpv-shim
  • jellyfin-mpv-shim.dist
  • kaffeine
  • ki
  • ki.dist
  • kodiPackages.inputstream-adaptive
  • kodiPackages.inputstream-ffmpegdirect
  • kodiPackages.inputstream-rtmp
  • kodiPackages.joystick
  • kodiPackages.libretro
  • kodiPackages.libretro-2048
  • kodiPackages.libretro-fuse
  • kodiPackages.libretro-genplus
  • kodiPackages.libretro-mgba
  • kodiPackages.libretro-nestopia
  • kodiPackages.libretro-snes9x
  • kodiPackages.pvr-hdhomerun
  • kodiPackages.pvr-hts
  • kodiPackages.pvr-iptvsimple
  • kodiPackages.pvr-vdr-vnsi
  • kodiPackages.steam-controller
  • kodiPackages.vfs-libarchive
  • kodiPackages.vfs-rar
  • kodiPackages.vfs-sftp
  • kodiPackages.visualization-fishbmc
  • kodiPackages.visualization-goom
  • kodiPackages.visualization-matrix
  • kodiPackages.visualization-pictureit
  • kodiPackages.visualization-projectm
  • kodiPackages.visualization-shadertoy
  • kodiPackages.visualization-spectrum
  • kodiPackages.visualization-starburst
  • kodiPackages.visualization-waveform
  • kphotoalbum
  • labwc
  • labwc.man
  • latte-dock
  • layan-kde
  • libsForQt5.bismuth
  • libsForQt5.krohnkite
  • libsForQt5.kwin-dynamic-workspaces
  • libsForQt5.kwin-tiling
  • libsForQt5.kzones
  • libsForQt5.parachute
  • libsForQt5.tokodon
  • lightly-boehs
  • lightly-qt
  • ludusavi
  • mate.mate-wayland-session
  • matrix-gtk-theme
  • mesa-demos
  • mnemosyne
  • mnemosyne.dist
  • mojave-gtk-theme
  • mpc-qt
  • nightfox-gtk-theme
  • nordic
  • nordic.sddm
  • plasma5Packages.bismuth
  • plasma5Packages.krohnkite
  • plasma5Packages.kwin-dynamic-workspaces
  • plasma5Packages.kwin-tiling
  • plasma5Packages.kzones
  • plasma5Packages.parachute
  • plasma5Packages.tokodon
  • python311Packages.flet
  • python311Packages.flet-runtime
  • python311Packages.flet-runtime.dist
  • python311Packages.flet.dist
  • python311Packages.py3status
  • python311Packages.py3status.dist
  • python311Packages.python-vlc
  • python311Packages.python-vlc.dist
  • python311Packages.qtile-extras
  • python311Packages.qtile-extras.dist
  • python312Packages.flet
  • python312Packages.flet-runtime
  • python312Packages.flet-runtime.dist
  • python312Packages.flet.dist
  • python312Packages.py3status
  • python312Packages.py3status.dist
  • python312Packages.python-vlc
  • python312Packages.python-vlc.dist
  • python312Packages.qtile-extras
  • python312Packages.qtile-extras.dist
  • qogir-kde
  • rivercarro
  • scenefx
  • shairport-sync
  • snapshot
  • sublime-music
  • sublime-music.dist
  • sway-contrib.grimshot
  • sway-contrib.grimshot.man
  • tokyonight-gtk-theme
  • utterly-nord-plasma
  • vimix-gtk-themes
  • vulkan-caps-viewer
  • waybox
  • wayfire
  • wayfirePlugins.firedecor
  • wayfirePlugins.focus-request
  • wayfirePlugins.wayfire-plugins-extra
  • wayfirePlugins.wayfire-shadows
  • wayfirePlugins.wcm
  • wayfirePlugins.wf-shell
  • wayfirePlugins.windecor
  • wayfirePlugins.wwp-switcher
  • whitesur-gtk-theme
  • whitesur-kde
  • wio
  • xarcan
  • ytui-music
  • zed-editor
1 package failed to build and already failed to build on hydra master:
57 packages built:
  • ani-cli
  • bite
  • cplay-ng
  • cplay-ng.dist
  • curseradio
  • curseradio.dist
  • darwin.moltenvk
  • darwin.moltenvk.bin
  • darwin.moltenvk.dev
  • dmlive
  • dolphin-emu
  • dra-cla
  • fastfetch
  • fastfetch.man
  • ff2mpv-go
  • gfxstream
  • gonic
  • gtk-pipe-viewer
  • gtk-pipe-viewer.devdoc
  • halloy
  • hydrus
  • hydrus.doc
  • invidtui
  • klipperscreen
  • koboldcpp
  • libplacebo
  • libplacebo_5
  • moonlight-qt
  • mov-cli
  • mov-cli.dist
  • mpv-unwrapped
  • mpv-unwrapped.dev
  • mpv-unwrapped.doc
  • mpv-unwrapped.man
  • ncnn
  • photoqt
  • pipe-viewer
  • pipe-viewer.devdoc
  • python311Packages.mpv
  • python311Packages.mpv.dist
  • python312Packages.mpv
  • python312Packages.mpv.dist
  • rbdoom-3-bfg
  • realesrgan-ncnn-vulkan
  • rutabaga_gfx
  • somafm-cli
  • subtitleedit
  • supersonic
  • tomato-c
  • vkquake
  • vulkan-loader
  • vulkan-loader.dev
  • vulkan-tools
  • wgpu-utils
  • wtwitch
  • youtube-tui
  • ytfzf

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

Details bite:

warning: EvalError
Cannot evaluate attribute ‘bite’ in ‘/nix/store/k44r8w48fjjmgw0q45r75jkvkh5kz13s-nixpkgs’.

cplay-ng.dist:

got build log for '/nix/store/y56jaw1mj6rr3azasrpbfpk2jvrxmqv3-cplay-ng-5.2.0-dist' from 'daemon'
When evaluating attribute ‘cplay-ng.dist’:
warning: no-python-tests
Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
Near pkgs/applications/audio/cplay-ng/default.nix:31:

   |
31 |     description = "Simple curses audio player";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-python-tests.md

cplay-ng:

got build log for '/nix/store/iqx0qss98sbf0flmx683jjsmhxzgi3yw-cplay-ng-5.2.0' from 'daemon'
When evaluating attribute ‘cplay-ng’:
warning: no-python-tests
Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
Near pkgs/applications/audio/cplay-ng/default.nix:31:

   |
31 |     description = "Simple curses audio player";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-python-tests.md

dmlive:

warning: EvalError
Cannot evaluate attribute ‘dmlive’ in ‘/nix/store/k44r8w48fjjmgw0q45r75jkvkh5kz13s-nixpkgs’.

gfxstream:

warning: EvalError
Cannot evaluate attribute ‘gfxstream’ in ‘/nix/store/k44r8w48fjjmgw0q45r75jkvkh5kz13s-nixpkgs’.

gonic:

warning: EvalError
Cannot evaluate attribute ‘gonic’ in ‘/nix/store/k44r8w48fjjmgw0q45r75jkvkh5kz13s-nixpkgs’.

halloy:

warning: EvalError
Cannot evaluate attribute ‘halloy’ in ‘/nix/store/k44r8w48fjjmgw0q45r75jkvkh5kz13s-nixpkgs’.

hydrus.doc:

got build log for '/nix/store/9ghm46gb9qa2m5223dg44zr85crbi8p8-python3.12-hydrus-581-doc' from 'daemon'
When evaluating attribute ‘hydrus.doc’:
warning: unused-argument
Unused argument: pythonOlder.
Near pkgs/applications/graphics/hydrus/default.nix:9:3:

  |
9 | , pythonOlder
  |   ^
hydrus:

got build log for '/nix/store/p48v01nqh4h1ckyh2inknjnd7fh3mngd-python3.12-hydrus-581' from 'daemon'
When evaluating attribute ‘hydrus’:
warning: unused-argument
Unused argument: pythonOlder.
Near pkgs/applications/graphics/hydrus/default.nix:9:3:

  |
9 | , pythonOlder
  |   ^
koboldcpp:

warning: EvalError
Cannot evaluate attribute ‘koboldcpp’ in ‘/nix/store/k44r8w48fjjmgw0q45r75jkvkh5kz13s-nixpkgs’.

libplacebo:

warning: EvalError
Cannot evaluate attribute ‘libplacebo’ in ‘/nix/store/k44r8w48fjjmgw0q45r75jkvkh5kz13s-nixpkgs’.

libplacebo_5:

warning: EvalError
Cannot evaluate attribute ‘libplacebo_5’ in ‘/nix/store/k44r8w48fjjmgw0q45r75jkvkh5kz13s-nixpkgs’.

mov-cli:

got build log for '/nix/store/c6h4mmwcf7kj27j760i46p8rmx3sdmni-python3.12-mov-cli-4.4.7' from 'daemon'
When evaluating attribute ‘mov-cli’:
warning: python-include-tests
Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

Near pkgs/by-name/mo/mov-cli/package.nix:63:

   |
63 |     description = "Cli tool to browse and watch movies";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

ncnn:

warning: EvalError
Cannot evaluate attribute ‘ncnn’ in ‘/nix/store/k44r8w48fjjmgw0q45r75jkvkh5kz13s-nixpkgs’.

photoqt:

warning: EvalError
Cannot evaluate attribute ‘photoqt’ in ‘/nix/store/k44r8w48fjjmgw0q45r75jkvkh5kz13s-nixpkgs’.

rbdoom-3-bfg:

warning: EvalError
Cannot evaluate attribute ‘rbdoom-3-bfg’ in ‘/nix/store/k44r8w48fjjmgw0q45r75jkvkh5kz13s-nixpkgs’.

realesrgan-ncnn-vulkan:

warning: EvalError
Cannot evaluate attribute ‘realesrgan-ncnn-vulkan’ in ‘/nix/store/k44r8w48fjjmgw0q45r75jkvkh5kz13s-nixpkgs’.

rerun:

warning: EvalError
Cannot evaluate attribute ‘rerun’ in ‘/nix/store/k44r8w48fjjmgw0q45r75jkvkh5kz13s-nixpkgs’.

rutabaga_gfx:

warning: EvalError
Cannot evaluate attribute ‘rutabaga_gfx’ in ‘/nix/store/k44r8w48fjjmgw0q45r75jkvkh5kz13s-nixpkgs’.

subtitleedit:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/8xrd1zfxif5lasz0w0wl7zmlcgvsrdjd-subtitleedit-4.0.6' from 'daemon'
When evaluating attribute ‘subtitleedit’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/applications/video/subtitleedit/default.nix:95:5:

   |
95 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

supersonic:

warning: EvalError
Cannot evaluate attribute ‘supersonic’ in ‘/nix/store/k44r8w48fjjmgw0q45r75jkvkh5kz13s-nixpkgs’.

tomato-c:

warning: EvalError
Cannot evaluate attribute ‘tomato-c’ in ‘/nix/store/k44r8w48fjjmgw0q45r75jkvkh5kz13s-nixpkgs’.

vkquake:

warning: EvalError
Cannot evaluate attribute ‘vkquake’ in ‘/nix/store/k44r8w48fjjmgw0q45r75jkvkh5kz13s-nixpkgs’.

vulkan-loader:

warning: EvalError
Cannot evaluate attribute ‘vulkan-loader’ in ‘/nix/store/k44r8w48fjjmgw0q45r75jkvkh5kz13s-nixpkgs’.

vulkan-tools:

warning: EvalError
Cannot evaluate attribute ‘vulkan-tools’ in ‘/nix/store/k44r8w48fjjmgw0q45r75jkvkh5kz13s-nixpkgs’.

wgpu-utils:

warning: EvalError
Cannot evaluate attribute ‘wgpu-utils’ in ‘/nix/store/k44r8w48fjjmgw0q45r75jkvkh5kz13s-nixpkgs’.

youtube-tui:

warning: EvalError
Cannot evaluate attribute ‘youtube-tui’ in ‘/nix/store/k44r8w48fjjmgw0q45r75jkvkh5kz13s-nixpkgs’.

gador
gador approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@gador gador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@gador gador merged commit 2ca45ae into NixOS:master Aug 1, 2024
@reckenrode reckenrode deleted the coredata-12.3-fixes branch October 6, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gador gador gador approved these changes

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reckenrode @gador