pdal: fix libdir path in pkgconfig file#331092
Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom Jul 31, 2024
Merged
Conversation
jopejoe1
reviewed
Jul 30, 2024
98751c2 to
91b755c
Compare
Co-authored-by: Johannes Jöns <[email protected]>
91b755c to
4cfab1b
Compare
Member
|
Also reminds me that we need a hook similar to cmake for this. |
Contributor
Author
Sorry, I don't understand this comment. |
Member
|
To many people did this wrong in cmake files that we just fail the build if this happens https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/cm/cmake/check-pc-files-hook.sh |
Contributor
Author
Great thanks, I didn't know about this hook ! |
imincik
added a commit
to imincik/geospatial-nix
that referenced
this pull request
Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix
libdirpath inlib/pkgconfig/pdal.pcfile.pdal.pcwithout the patch:pdal.pcwith the patch:Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.