Skip to content

python3Packages.python-etcd: disable tests on aarch64#331082

Merged
emilazy merged 1 commit intoNixOS:masterfrom
adamcstephens:python-etcd/aarch64-tests
Jul 31, 2024
Merged

python3Packages.python-etcd: disable tests on aarch64#331082
emilazy merged 1 commit intoNixOS:masterfrom
adamcstephens:python-etcd/aarch64-tests

Conversation

@adamcstephens
Copy link
Contributor

Description of changes

aarch64 is not fully supported, causing the build to fail due to test errors

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

aarch64 is not fully supported, causing the build to fail due to test errors
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 30, 2024
@Sigmanificient Sigmanificient requested a review from emilazy July 30, 2024 13:07
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 30, 2024
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m very sorry about this. I don’t tend to think about potential platform differences when Python is involved, and am inattentive to partial ofborg results because of the Darwin builders being constantly clogged up, but in this case I should have at least done a run on the AArch64 community box. I will try to be more careful in future.

I wanted to check – do you know if this package mostly works on AArch64 despite the tests failing or is this just to get other builds unblocked?

@emilazy
Copy link
Member

emilazy commented Jul 31, 2024

Result of nixpkgs-review pr 331082 run on aarch64-linux 1

6 packages built:
  • patroni
  • patroni.dist
  • python311Packages.python-etcd
  • python311Packages.python-etcd.dist
  • python312Packages.python-etcd
  • python312Packages.python-etcd.dist

@emilazy emilazy merged commit 6b1a95c into NixOS:master Jul 31, 2024
@adamcstephens
Copy link
Contributor Author

I wanted to check – do you know if this package mostly works on AArch64 despite the tests failing or is this just to get other builds unblocked?

I expect this works, but I can’t confirm. From my brief research into etcd on aarch64 it seems that it should work fine on the older releases but was marked as unsupported for whatever reasons.

I only stumbled over the breakage because the patroni bump failed to build on aarch64-linux.

Thanks @emilazy. I completely understand the impatience with slow CI and often merge without waiting on Darwin myself.

@adamcstephens adamcstephens deleted the python-etcd/aarch64-tests branch July 31, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants