python3Packages.flask-restful: drop nose dependency#330876

Merged

gador merged 1 commit intoNixOS:masterfrom

Sigmanificient:flask-restful-attempt-2

Aug 7, 2024

Member

Sigmanificient commented Jul 29, 2024

Description of changes

python3Packages: get rid of uses of nose #326513

Things done

Add a 👍 reaction to pull requests you find important.


          python3Packages.flask-restful: drop nose dependency

821e00b

github-actions bot added the 6.topic: python label

Sigmanificient mentioned this pull request

python3Packages: get rid of uses of nose #326513

Closed

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels

Member

emilazy commented Jul 31, 2024

This package is abandoned‐ish upstream and has been patched out of at least one package in‐tree (# flask-restful is unmaintained and breaks regularly, don't depend on it).

The remaining two users are wsme (unused, abandoned, repository is gone) and changedetection-io. The latter is actively updated and does still depend on this library upstream. @MikaelFangel Do you know if they have any intentions of moving off this deprecated library?

Contributor

MikaelFangel commented Aug 5, 2024

I unfortunately don't know what the plans for changedetection-io is.

gador reviewed

View reviewed changes

pkgs/development/python-modules/flask-restful/default.nix Show resolved Hide resolved

Contributor

Pizmovc commented Aug 7, 2024

I can confirm that changedetection-io (which depends on this package) can now be built, while without this PR it can not be 👍

Member

gador commented Aug 7, 2024

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 330876 run on x86_64-linux 1

7 packages built:

changedetection-io
changedetection-io.dist
nixpkgs-manual
python311Packages.flask-restful
python311Packages.flask-restful.dist
python312Packages.flask-restful
python312Packages.flask-restful.dist

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

Details

nixpkgs-manual:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

python311Packages.flask-restful.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/adzzwzaqysbhwxjmc7k2dgka2l3y2464-python3.11-flask-restful-0.3.10-dist' from 'daemon'
When evaluating attribute ‘python311Packages.flask-restful.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/flask-restful/default.nix:76:5:

   |
76 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python311Packages.flask-restful:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/adlp6hq0ff9h6ki67gqpl82gsg1i35hv-python3.11-flask-restful-0.3.10' from 'daemon'
When evaluating attribute ‘python311Packages.flask-restful’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/flask-restful/default.nix:76:5:

   |
76 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.flask-restful.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/j9254kby615b2mj6qdj7m2kn112sfmwj-python3.12-flask-restful-0.3.10-dist' from 'daemon'
When evaluating attribute ‘python312Packages.flask-restful.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/flask-restful/default.nix:76:5:

   |
76 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.flask-restful:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/c0czn83fqkm45awxyjiyldx8wxkwyai4-python3.12-flask-restful-0.3.10' from 'daemon'
When evaluating attribute ‘python312Packages.flask-restful’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/flask-restful/default.nix:76:5:

   |
76 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

gador approved these changes

View reviewed changes

gador merged commit c26018c into NixOS:master

Member

emilazy commented Aug 9, 2024

This didn’t actually remove the nose dependency.

Member Author

Sigmanificient commented Aug 9, 2024

I forget to remove it in the arguments! 😥

Member

emilazy commented Aug 10, 2024

No worries; feel free to open another PR for it or I might get around to it if not.

Sigmanificient mentioned this pull request

python312Packages.flask-restful: remove unused nose argument #333579

Merged

13 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10